Improve launcher logging - Part 2#367
Merged
MikeSpreitzer merged 2 commits intollm-d-incubation:mainfrom Mar 20, 2026
Merged
Conversation
- Add Content-Range header to 200 OK log responses (not just 206) - Remove dead-code guard on actual_end calculation - Improve get_log_bytes docstring: clarify inclusive semantics and return value - Add explanatory comment in parse_range_header for open-ended ranges - Update log endpoint docstring with RFC 9110 §14 reference - Log CLI arguments on launcher startup with logging.basicConfig() setup - Fix test mock total (29→30) and assert Content-Range on 200 responses Signed-off-by: Diego-Castan <diego.castan@ibm.com>
Collaborator
MikeSpreitzer
left a comment
MikeSpreitzer
left a comment
There was a problem hiding this comment.
I left some independent comments.
Collaborator
|
/ok-to-test |
|
🚀 E2E tests triggered by /ok-to-test |
MikeSpreitzer
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Address review feedback from Issue #320 (RFC 9110 compliance improvements for the log endpoint) and implement Issue #338
(log CLI arguments on launcher startup).
Test plan: