update Gateway TLS field to certificateRefs to fix validation error#243
Open
D-Sai-Venkatesh wants to merge 1 commit intollm-d-incubation:mainfrom
Open
update Gateway TLS field to certificateRefs to fix validation error#243D-Sai-Venkatesh wants to merge 1 commit intollm-d-incubation:mainfrom
D-Sai-Venkatesh wants to merge 1 commit intollm-d-incubation:mainfrom
Conversation
…lm-d-incubation#242) Signed-off-by: D-Sai-Venkatesh <suryasai.venkatesh@gmail.com>
D-Sai-Venkatesh
requested review from
Gregory-Pereira,
nerdalert,
robertgshaw2-redhat and
tlrmchlsmth
as code owners
Contributor
|
Have open #247 |
|
This PR is marked as stale after 21d of inactivity. After an additional 14d of inactivity (7d to become rotten, then 7d more), it will be closed. To prevent this PR from being closed, add a comment or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
gateway.yamltemplate to usecertificateRefs(an array) instead ofcertificateRef(a single object) in the TLS configuration section. This change aligns the chart with the Kubernetes Gateway API specification.Related Issue
#242
Changes Made
charts/llm-d-infra/templates/gateway-infrastructure/gateway.yamlto iterate overcertificateRefs.charts/llm-d-infra/values.yamlto reflect the new array structure in examples and schema annotations.values.schema.json) via pre-commit hooks.