Enhance: ignore add nvidia.com/gpu when use vllm-cpu image#229
Open
yyzxw wants to merge 1 commit intollm-d-incubation:mainfrom
Open
Enhance: ignore add nvidia.com/gpu when use vllm-cpu image#229yyzxw wants to merge 1 commit intollm-d-incubation:mainfrom
yyzxw wants to merge 1 commit intollm-d-incubation:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm chart’s accelerator resource resolution so that GPU resources (e.g., nvidia.com/gpu) are not automatically added when a CPU-only vLLM image is used.
Changes:
- Adjust
llm-d-modelservice.acceleratorResourceto return no accelerator resource when the container image name suggests CPU usage (in addition to the existing inference-sim exception).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: zxw <1020938856@qq.com>
yyzxw
force-pushed
the
fix/remove-resource-if-cpu
branch
from
93ffc27 to
b00a2e3
Compare
Collaborator
|
Please update the issue with more information about this image and why it should be an exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #228
ref: https://docs.vllm.ai/en/stable/getting_started/installation/cpu/#set-up-using-docker