Fixes failing CI on pre-commit and lint#251
Merged
jgchn merged 1 commit intollm-d-incubation:mainfrom Apr 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes failing CI on #247 which was merged in by github-actions bot before CI finished running.
How was this tested?
values.schema.jsonandvalues.schema.tmpl.jsonto include thedeploymentStrategyfields added in Make Deployment strategy configurable #247 (thehelm-schemaandjsonschema-dereferencepre-commit hooks were never run before merge)charts/llm-d-modelservice/charts/to.gitignoreto prevent Helm dependency charts (e.g. Bitnamicommon) from being tracked or linted by pre-commitFixes the two failing CI checks from #247:
Pre-commit(helm-schema and jsonschema-dereference hooks)Lint and Test Charts(ct lint fails when schema is stale)Checklist
git commit -s) per DCOmake pre-commit-run)make lint)make verify)make bump-chart-version-{patch|minor|major})Related Issues