[DO NOT REVIEW YET] fix: Harden BenchmarkRepository init and serialization#110
Draft
amito wants to merge 1 commit intollm-d-incubation:mainfrom
Draft
[DO NOT REVIEW YET] fix: Harden BenchmarkRepository init and serialization#110amito wants to merge 1 commit intollm-d-incubation:mainfrom
amito wants to merge 1 commit intollm-d-incubation:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Collaborator
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
amito
changed the title
amito
force-pushed
the
fix/benchmark-repo-init
branch
from
3a1d472 to
56b1a36
Compare
amito
changed the title
- Add missing `estimated` field to BenchmarkData.to_dict() for round-trip - Make DB connection lazy (validate_connection=False by default) so ConfigFinder() doesn't fail when Postgres is unavailable - Remove hardcoded password from fallback DSN - Stop logging raw database URL on connection failure Signed-off-by: Amit Oren <amoren@redhat.com>
amito
force-pushed
the
fix/benchmark-repo-init
branch
from
56b1a36 to
f218a38
Compare
namasl
added a commit
that referenced
this pull request
Mar 26, 2026
* Partially resolves #110 by exposing every single image as env vars Each image is now defined by a tripe of environment variables with suffixes `_REGISTRY`, `_REPO` and `_TAG` A new function, `get_latest_image` will produce the correct image fqn Also, fixed a small bug on `teardown` (delete `pod` **before** deleting pvc) Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/env.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/run.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/05_ensure_harness_namespace_prepared.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/06_deploy_vllm_standalone_models.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/07_invoke_llm-d-deployer.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/07_invoke_llm-d-deployer.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/07_invoke_llm-d-deployer.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/07_invoke_llm-d-deployer.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/07_invoke_llm-d-deployer.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/08_smoketest.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> * Update setup/steps/08_smoketest.sh Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com> Signed-off-by: maugustosilva <maugusto.silva@gmail.com> --------- Signed-off-by: maugustosilva <maugusto.silva@gmail.com> Co-authored-by: Nick Masluk <144150872+namasl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.