Skip to content

Minor additions to Makefile#116

Merged
anfredette merged 2 commits intollm-d-incubation:mainfrom
amito:feature/makefile-minor-fixes
Mar 19, 2026
Merged

Minor additions to Makefile#116
anfredette merged 2 commits intollm-d-incubation:mainfrom
amito:feature/makefile-minor-fixes

Conversation

@amito
Copy link
Copy Markdown
Collaborator

@amito amito commented Mar 17, 2026

Fixes:

  1. Make sure ruff exists before trying to run it. Fixes minor issues in the lint and format Makefile targets where we always printed out "ruff is not installed".

New features:

  1. Add a typecheck Makefile target which runs mypy.

Summary by CodeRabbit

Release Notes

  • Chores
    • Enhanced build system resilience: development tools (linting, formatting, type checking) now gracefully handle cases when tools are unavailable.
    • Added type checking capability as a new build command.
    • Improved build process messaging for clarity.

amito added 2 commits March 18, 2026 00:12
Signed-off-by: Amit Oren <amoren@redhat.com>
Signed-off-by: Amit Oren <amoren@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 52bca7a9-2f3d-4043-abe2-45db54688f22

📥 Commits

Reviewing files that changed from the base of the PR and between 62d0219 and 04b7547.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

Makefile updated to add a new typecheck target for running mypy and modify existing lint and format targets to conditionally execute only when respective tools are installed, with graceful skipping when unavailable.

Changes

Cohort / File(s) Summary
Makefile Build Targets
Makefile
Added typecheck target for mypy execution via uv. Modified lint and format targets to check tool availability before execution; skips with warning if not installed. Updated clean target message text.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Minor additions to Makefile' is vague and generic, using non-descriptive language that doesn't clearly convey the specific changes made (adding typecheck target and fixing conditional ruff execution). Use a more specific title that highlights the main changes, such as 'Add typecheck target and fix conditional ruff execution in Makefile' or 'Add mypy typecheck target and guard ruff commands in Makefile'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amito amito requested a review from anfredette March 17, 2026 22:15
Copy link
Copy Markdown
Collaborator

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@anfredette anfredette merged commit 3319c00 into llm-d-incubation:main Mar 19, 2026
7 checks passed
anfredette added a commit that referenced this pull request Mar 26, 2026
namasl pushed a commit that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants