Move config explorer into neuralnav package#146
Merged
jgchn merged 8 commits intollm-d-incubation:mainfrom Apr 1, 2026
Merged
Conversation
Signed-off-by: Jing Chen <jing.chen2@ibm.com>
Signed-off-by: Jing Chen <jing.chen2@ibm.com>
Fix type annotation errors in capacity_planner.py, gpu_recommender.py,
planner_cli.py, and test_capacity_planner.py to pass mypy --warn_return_any
and ruff checks without suppression:
- capacity_planner: use Any for dynamic AutoConfig attributes (get_text_config,
get_quantization_config, get_model_config_from_hf return Any); fix float/int
annotation mismatches (precision_in_bytes, memory accumulator, bytes_to_gib
signature, total_kv_blocks cast); add assert guards for MLA None fields;
replace reduce(list.__add__) with set comprehension; fix missing return in
get_quant_bytes; rename local vars to avoid AutoConfig re-assignment confusion
- gpu_recommender: annotate dict[str, Any] return types, wrap json.load() in
dict(), cast float for cost calculation, init dicts as {} not None
- planner_cli: annotate result/error_groups dicts as dict[str, Any]
- test_capacity_planner: add noqa B017 for unknowable HF exception type
Assisted-by: Claude <noreply@anthropic.com>
Signed-off-by: Jing Chen <jing.chen2@ibm.com>
Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Jing Chen <jing.chen2@ibm.com>
anfredette
requested changes
Apr 1, 2026
Collaborator
There was a problem hiding this comment.
Overall, this looks good, but a few more changes are needed (mainly due to my pr #147 being merged) :
- Rebase on main, update all neuralnav → planner imports
- Capacity_Planner doesn't show up in the sidebar. To fix that, move ui/Capacity_Planner.py → ui/pages/1_Capacity_Planner.py (and fix the Path reference).
- Mention #132 in PR body (UI integration is addressed)
- Mention #133 in PR body (config_explorer directory is removed)
- Fix the pyproject.toml entry point module path
- Preserve config_explorer/README.md as docs/CONFIG_EXPLORER.md per #133 until we fully integrate it into the other docs
- Fix the monkeypatch.setattr string in test_capacity_planner.py
Signed-off-by: Jing Chen <jing.chen2@ibm.com>
Signed-off-by: Jing Chen <jing.chen2@ibm.com>
Signed-off-by: Jing Chen <jing.chen2@ibm.com>
anfredette
approved these changes
Apr 1, 2026
Collaborator
anfredette
left a comment
anfredette
left a comment
There was a problem hiding this comment.
I tested this before your last commit. It all looks good to me now.
I'm approving it. Do we want @namasl to look at it before we merge it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131
Closes #132
Closes #133