Throttle workers during worker pool message ingestion#347
Draft
jtechapps wants to merge 1 commit into
Draft
Conversation
- added worker ids for worker pools.
- use pool gate Budget to calculate the number of active workers before
pulling a request from the request channel for a worker pool
- throttled high-ID workers (workerID > activeLimit) sleep in the polling
loop without popping messages from memory channels.
- set async_dispatch_budget{pool_name=...} metric for worker pool gate
saturation.
- at least 1 active worker when budget is 0 so that tier priority gate
can drop/redeliver any non-reserved interactive or batch messages.
Signed-off-by: Jacob Murry <jacobmurry@google.com>
Collaborator
Author
|
I will add a release note. I am also testing this now using queue clearing benchmark to ensure throughput is maintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR throttles request message ingestion into a worker pool from the merged request channel by sleeping workers based on the admission gate Budget().
Why is this change needed?
Fixes: #304
Fixes: #141
How was this tested?
Checklist
git commit -s) per DCOmake test)make lint)Related Issues
Release note