fix(release-notes): trim trailing blank line from assembled RELEASE-NOTES.md#349
Open
shimib wants to merge 1 commit into
Open
fix(release-notes): trim trailing blank line from assembled RELEASE-NOTES.md#349shimib wants to merge 1 commit into
shimib wants to merge 1 commit into
Conversation
The assembled section ends with a blank separator; on the first release (nothing after the marker) that blank lands at EOF, which the end-of-file-fixer pre-commit hook rejects. Trim trailing blank lines after assembly so RELEASE-NOTES.md ends with exactly one newline; internal blank separators between release sections are preserved. Signed-off-by: Shimi Bandiel <shimib@google.com>
shimib
requested review from
RishabhSaini,
ahg-g,
evacchi and
jtechapps
as code owners
July 24, 2026 17:17
jtechapps
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
hack/assemble-release-notes.shends each assembled section with a blank separator line. On the first release (nothing after the<!-- BEGIN RELEASES -->marker), that blank lands at EOF, and theend-of-file-fixerpre-commit hook rejects the file — which is exactly what happened while preparing v0.8.0 in #348.This adds a post-assembly trim so
RELEASE-NOTES.mdalways ends with exactly one newline. Internal blank separators between release sections are preserved (the trim only removes trailing blanks).Testing
Release note