fixing cross builds#112
Merged
vMaroon merged 1 commit intollm-d:mainfrom May 19, 2025
Gregory-Pereira:fix-cross-builds
Merged
Conversation
Signed-off-by: greg pereira <grpereir@redhat.com>
Member
Author
|
cc @oglok, he can verify this works |
Member
Author
|
CI fails due to a CI related issue: gotta be an org / auth thing. cc @clubanderson Let me know how I can fix this, will try to cleanup my own messes 🙃 |
Member
|
@Gregory-Pereira we currently have a "hack" where a token for importing the private We didn't disclose this as this token will be dropped tomorrow. |
vMaroon
approved these changes
May 19, 2025
mayabar
approved these changes
May 19, 2025
pierDipi
pushed a commit
to pierDipi/llm-d-inference-scheduler
that referenced
this pull request
Nov 28, 2025
…gest to 84286c7 (llm-d#112) Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross builds were failing in the process of rebuilding from my ENV when adjusting blocksize to test prefix aware routing demo.
Issue:
platformwas not specified on the container, so it was pullingaarch64base images. Then all the go build stuff would target linux/amd64 on top of anaarch64image causing cross build issues. When specifying same platform to the image builds we get success.Tested with:
Builds on mac.