Skip to content

[DO NOT MERGE] test: verify signing and DCO#116

Closed
elevran wants to merge 12 commits intomainfrom
dco_check
Closed

[DO NOT MERGE] test: verify signing and DCO#116
elevran wants to merge 12 commits intomainfrom
dco_check

Conversation

@elevran
Copy link
Collaborator

@elevran elevran commented May 19, 2025

The below is for using SSH keys. GPG keys will be similar.
Note that -S and -s are both required. The -s or --signoff simply adds a Signed-Off-By statement and the -S signing uses private-public cryptographic keys to verify the user making the commit.

Prerequisites

user.signingkey=~/.ssh/<private key file>
user.email=<your email - should match the email used in the key pair>
user.name=<your full name> 
gpg.format=ssh
commit.gpgsign=true # automatically sign commits, no need for `-S` 
  • Make sure to add the PUBLIC part of the key to GitHub. It MUST be added as a SIGNING key. You may also add it as an authentication key to GH (i.e., it will be added twice).

Add an empty commit to this PR and watch for the green verified mark next to it

git fetch upstream dco_check
git checkout dco_check
# -S is only needed if commit.gpgsign=true was not set in git config above. Does not hurt to add anyway...
git commit --allow-empty -S -s -m "test: verify signing and DCO"
git push upstream --set-upstream dco_check

elevran and others added 12 commits May 19, 2025 13:03
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Maroon Ayoub <maroon.ayoub@ibm.com>
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Signed-off-by: Ira <IRAR@il.ibm.com>
Signed-off-by: Michal <michal.malka@ibm.com>
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
@elevran elevran closed this May 20, 2025
@elevran elevran deleted the dco_check branch May 20, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants