Closed
Conversation
shmuelk
requested changes
May 22, 2025
Collaborator
shmuelk
left a comment
shmuelk
left a comment
There was a problem hiding this comment.
I think some of the changes mentioned here were already done in a previous PR
Lint errors need changes to the lint configuration.
pkg/scheduling/pd/scheduler_test.go
Outdated
| "github.com/llm-d/llm-d-inference-scheduler/pkg/config" | ||
| "github.com/llm-d/llm-d-inference-scheduler/pkg/scheduling/pd" | ||
| "github.com/llm-d/llm-d-inference-scheduler/pkg/scheduling/plugins/filter" | ||
| . "github.com/onsi/ginkgo/v2" |
Collaborator
There was a problem hiding this comment.
See PR llm-d/llm-d-inference-sim#20 to see how to eliminate the dot import lint errors for the two Ginkgo imports.
Jooho
pushed a commit
to Jooho/llm-d-inference-scheduler
that referenced
this pull request
Sep 17, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use appropriate configuration when pd scheduler is created, check prefill header when required
Ref #56