update GIE upstream version + code adaptations#135
Merged
nirrozenbaum merged 2 commits intollm-d:mainfrom May 22, 2025
Merged
Conversation
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
elevran
previously approved these changes
May 22, 2025
Collaborator
elevran
left a comment
There was a problem hiding this comment.
all good (with the exception of using k8sscorer for package renames - consider fixing).
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
shmuelk
pushed a commit
to shmuelk/llm-d-inference-scheduler
that referenced
this pull request
May 29, 2025
* update GIE upstream version + code adaptations Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * addressed code review comments Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
shmuelk
added a commit
that referenced
this pull request
May 29, 2025
* Removed unused make targets and set default tag to dev Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Changed kind development deployer to use dev tag for EPP and Simulator Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Updated documentation to reflect changes Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Removed local change Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Use correct variable in the Makefile Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * Mention the vLLM simulator in the kind environment documentation Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> * update GIE upstream version + code adaptations (#135) * update GIE upstream version + code adaptations Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * addressed code review comments Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * test: Improve scheduler test (#139) * Check headers, more tests for pd scheduler Signed-off-by: Ira <IRAR@il.ibm.com> * Moved config and context out of the loop, added logger to the context Signed-off-by: Ira <IRAR@il.ibm.com> * Removed comment and debug prints Signed-off-by: Ira <IRAR@il.ibm.com> --------- Signed-off-by: Ira <IRAR@il.ibm.com> * Wait for storage pods to exist before moving on (#138) Signed-off-by: David Martin <davmarti@redhat.com> * dependabot configuration for Go, GH acions and Docker Signed-off-by: Etai Lev Ran <elevran@gmail.com> * link checker - fails PR if links are broken (#130) * link checker - fails PR if links are broken Signed-off-by: Andy Anderson <andy@clubanderson.com> * replace markdown-link-check tool with lychee * remove markdown-link-check tool custom action * make README links relative * increase timeouts and ignore gnu's website since it throttles by timeouts Signed-off-by: Etai Lev Ran <elevran@gmail.com> --------- Signed-off-by: Etai Lev Ran <elevran@gmail.com> Co-authored-by: Etai Lev Ran <elevran@gmail.com> * Corrected name of vLLM simulator Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> --------- Signed-off-by: Shmuel Kallner <kallner@il.ibm.com> Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> Signed-off-by: Ira <IRAR@il.ibm.com> Signed-off-by: David Martin <davmarti@redhat.com> Signed-off-by: Etai Lev Ran <elevran@gmail.com> Co-authored-by: Nir Rozenbaum <nirro@il.ibm.com> Co-authored-by: Ira Rosen <irar@il.ibm.com> Co-authored-by: David Martin <david-martin@users.noreply.github.com> Co-authored-by: Etai Lev Ran <elevran@gmail.com> Co-authored-by: Andy Anderson <andy@clubanderson.com>
Jooho
pushed a commit
to Jooho/llm-d-inference-scheduler
that referenced
this pull request
Sep 17, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates upstream version to latest main (latest as of writing this text).
SchedulerConfig in upstream went through some changes. now it's no longer required to provide ALL plugins (no need to pass those that are not in use). the SchedulerConfig creation uses the
Withfunctions to specify plugins for specific type.further improvements can be done, but leaving it for follow up PRs to keep this one tightly scoped to version update.