Prefix aware scorer initialization#143
Merged
elevran merged 9 commits intollm-d:mainfrom Jun 18, 2025
Merged
Conversation
elevran
requested changes
May 27, 2025
Contributor
Author
|
Ref #55 |
vMaroon
reviewed
Jun 1, 2025
vMaroon
reviewed
Jun 1, 2025
Collaborator
|
@mayabar what's the status and next steps on this one? |
Contributor
Author
elevran
previously approved these changes
Jun 16, 2025
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
- remove PREFIX_SCORER_MAX_BLOCK_CACHE_SIZE, which will be defined internally - update names of configuration variables in prefix scorer configuration Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Add explanation for prefix scorer's environment variable by Maroon Co-authored-by: Maroon Ayoub <Maroonay@gmail.com> Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Add cache block size variable description (Maroon) Co-authored-by: Maroon Ayoub <Maroonay@gmail.com> Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
c29f1cd to
2c95dc1
Compare
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Contributor
Author
|
@shmuelk updated default values variables comment by your request |
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
shmuelk
approved these changes
Jun 18, 2025
elevran
approved these changes
Jun 18, 2025
Jooho
pushed a commit
to Jooho/llm-d-inference-scheduler
that referenced
this pull request
Sep 30, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use environment variables to define prefix scorer configuration