Skip to content

Prefix aware scorer initialization#143

Merged
elevran merged 9 commits intollm-d:mainfrom
mayabar:prefix-aware-initialization
Jun 18, 2025
Merged

Prefix aware scorer initialization#143
elevran merged 9 commits intollm-d:mainfrom
mayabar:prefix-aware-initialization

Conversation

@mayabar
Copy link
Contributor

@mayabar mayabar commented May 27, 2025

Use environment variables to define prefix scorer configuration

@mayabar mayabar requested review from elevran and shmuelk May 27, 2025 09:13
@mayabar mayabar requested review from elevran and vMaroon May 29, 2025 11:01
@mayabar
Copy link
Contributor Author

mayabar commented May 29, 2025

Ref #55

@mayabar mayabar requested a review from vMaroon June 3, 2025 06:54
@elevran
Copy link
Collaborator

elevran commented Jun 11, 2025

@mayabar what's the status and next steps on this one?

@mayabar
Copy link
Contributor Author

mayabar commented Jun 16, 2025

@mayabar what's the status and next steps on this one?

@elevran I updated my branch from llm-d/main and ready for merge, please re-review

elevran
elevran previously approved these changes Jun 16, 2025
mayabar and others added 7 commits June 18, 2025 10:16
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
- remove PREFIX_SCORER_MAX_BLOCK_CACHE_SIZE, which will be defined internally
- update names of configuration variables in prefix scorer configuration

Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Add explanation for prefix scorer's environment variable by Maroon

Co-authored-by: Maroon Ayoub <Maroonay@gmail.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Add cache block size variable description (Maroon)

Co-authored-by: Maroon Ayoub <Maroonay@gmail.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
@mayabar
Copy link
Contributor Author

mayabar commented Jun 18, 2025

@shmuelk updated default values variables comment by your request

@mayabar mayabar requested a review from elevran June 18, 2025 09:31
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
@elevran elevran merged commit f9172a9 into llm-d:main Jun 18, 2025
2 checks passed
@mayabar mayabar deleted the prefix-aware-initialization branch June 18, 2025 13:56
Jooho pushed a commit to Jooho/llm-d-inference-scheduler that referenced this pull request Sep 30, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants