fix: Cleanup build and kind development environment#156
Conversation
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
| @command -v golangci-lint >/dev/null 2>&1 || { \ | ||
| echo "❌ golangci-lint is not installed. Install from https://golangci-lint.run/usage/install/"; exit 1; } | ||
|
|
||
| .PHONY: check-jq |
There was a problem hiding this comment.
Don't remove that, it's good to check this
There was a problem hiding this comment.
We don't use jq anymore. It was used to read the .version.json file
| echo "✅ Using builder: $(BUILDER)"; \ | ||
| fi | ||
|
|
||
| .PHONY: check-podman |
There was a problem hiding this comment.
Don't remove that, it's good to check this
There was a problem hiding this comment.
podman was used explicitly in the tekton build pipeline, which isno longer used.
One doesn't need to have podman installed. There is a check for one's container tool which is either docker or podman as appropriate.
Makefile
Outdated
|
|
||
| .PHONY: env-dev-kind | ||
| env-dev-kind: image-build | ||
| env-dev-kind: |
There was a problem hiding this comment.
You should keep that before we run the kind
There was a problem hiding this comment.
why not to add 2 targets for installation on kind - one which includes image build and another one without build?
There was a problem hiding this comment.
Fixed. I added back the dependency.
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
DEVELOPMENT.md
Outdated
| EPP_TAG=0.0.4 make env-dev-kind | ||
| ``` | ||
|
|
||
| **NOTE:** If you want to load a different tag of the llm-d-inference-simulator, you can use the environment variable `VLLM_SIMULATOR_TAG` to specify it. |
There was a problem hiding this comment.
llm-d-inference-simulator -> llm-d-inference-sim
* update GIE upstream version + code adaptations Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * addressed code review comments Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
* Check headers, more tests for pd scheduler Signed-off-by: Ira <IRAR@il.ibm.com> * Moved config and context out of the loop, added logger to the context Signed-off-by: Ira <IRAR@il.ibm.com> * Removed comment and debug prints Signed-off-by: Ira <IRAR@il.ibm.com> --------- Signed-off-by: Ira <IRAR@il.ibm.com>
Signed-off-by: David Martin <davmarti@redhat.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
* link checker - fails PR if links are broken Signed-off-by: Andy Anderson <andy@clubanderson.com> * replace markdown-link-check tool with lychee * remove markdown-link-check tool custom action * make README links relative * increase timeouts and ignore gnu's website since it throttles by timeouts Signed-off-by: Etai Lev Ran <elevran@gmail.com> --------- Signed-off-by: Etai Lev Ran <elevran@gmail.com> Co-authored-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
8 participants
This PR:
devEPP_TAGenvironment variable is now used to set a different tag when building the image or running under kind.devto match the default image tag used when building the lm-d-inference-sim locally.