Consolidate PrefillFilter and DecodeFilter to one class#161
Closed
mayabar wants to merge 5 commits intollm-d:mainfrom
Closed
Consolidate PrefillFilter and DecodeFilter to one class#161mayabar wants to merge 5 commits intollm-d:mainfrom
mayabar wants to merge 5 commits intollm-d:mainfrom
Conversation
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
shmuelk
requested changes
Jun 3, 2025
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
fix typo Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
shmuelk
approved these changes
Jun 3, 2025
elevran
reviewed
Jun 3, 2025
Collaborator
There was a problem hiding this comment.
Can this leverage by_label.go as the base?
nirrozenbaum
reviewed
Jun 4, 2025
| ds, | ||
| scheduler.generateSchedulerConfig(ctx, schedCfg.PrefillSchedulerPlugins, | ||
| &filter.PrefillFilter{}), | ||
| filter.NewPrefillFilter()), |
Collaborator
There was a problem hiding this comment.
nit: seems like we could have remove the NewPrefillFilter and NewDecodeFilter functions and just use here:
filter.NewRoleBasedFilter("prefill-filter", filter.RolePrefill)(same for decode).
Collaborator
|
@mayabar - What is the status of this PR? |
Contributor
Author
|
Closed because the issue was fixed by #188 |
Jooho
pushed a commit
to Jooho/llm-d-inference-scheduler
that referenced
this pull request
Sep 30, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new class - RoleFilter
Role filter is initialized with list of roles and filters out all pods that are marked with role that is not in the list.
Used for Prefill and Decode filtering