Merged
Conversation
nirrozenbaum
force-pushed
the
config-change
branch
from
c277812 to
60efde2
Compare
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
nirrozenbaum
force-pushed
the
config-change
branch
from
60efde2 to
72f7586
Compare
mayabar
suggested changes
Jun 5, 2025
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
elevran
approved these changes
Jun 10, 2025
mayabar
approved these changes
Jun 10, 2025
mayabar
pushed a commit
to mayabar/llm-d-inference-scheduler
that referenced
this pull request
Jun 15, 2025
* simplify config Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * addressed code review comment from mayabar Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
pierDipi
pushed a commit
to pierDipi/llm-d-inference-scheduler
that referenced
this pull request
Nov 28, 2025
don't use epel dnf repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the code in pkg/config in the following manner:
NewConfig(which returns *Config) and thenconfig.LoadConfig(), which overrides the default values that were filled in the NewConfig func.following best practices, a common practice (instead of the existing logic) is to have instead a
LoadConfigfunction that returns*Configand remove theNewConfigfunction completely.