Refactor Redis configuration handling in KV cache scorer#172
Merged
vMaroon merged 2 commits intollm-d:mainfrom Jun 11, 2025
Merged
Refactor Redis configuration handling in KV cache scorer#172vMaroon merged 2 commits intollm-d:mainfrom
vMaroon merged 2 commits intollm-d:mainfrom
Conversation
Contributor
Author
|
Convo from previous PR that I accidentally closed when fixing lints: #172 |
relyt0925
force-pushed
the
redis-auth-support
branch
from
309e16a to
85e0107
Compare
Contributor
Author
|
@vMaroon for when you have a moment! |
vMaroon
approved these changes
Jun 5, 2025
Member
vMaroon
left a comment
vMaroon
left a comment
There was a problem hiding this comment.
LGTM
@elevran I suggest we accept this as it does make configuration easier from outside. In future iterations of the llm-d-kv-cache-manager, we can further hide the configuration, although I expect that the interaction with the latter will significantly change.
Member
|
@relyt0925 pls update PR base. |
relyt0925
force-pushed
the
redis-auth-support
branch
from
85e0107 to
8afc197
Compare
Contributor
Author
|
Updated to be based on latest! |
Replace direct Redis address assignment with URL parsing for better configuration management. This ensures proper error handling and compatibility with Redis connection options. Added Redis client dependency to facilitate this change. Signed-off-by: Tyler Lisowski <lisowski@us.ibm.com>
relyt0925
force-pushed
the
redis-auth-support
branch
from
8afc197 to
dc6c327
Compare
Contributor
Author
|
@vMaroon reupdated! |
elevran
approved these changes
Jun 11, 2025
Collaborator
|
Thanks @relyt0925 - looks good to merge! |
Jooho
pushed a commit
to Jooho/llm-d-inference-scheduler
that referenced
this pull request
Sep 30, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct Redis address assignment with URL parsing for better configuration management. This ensures proper error handling and compatibility with Redis connection options. Added Redis client dependency to facilitate this change.