Make URL construction IPv6-compatible#182
Merged
elevran merged 1 commit intollm-d:mainfrom Jun 17, 2025
Merged
Conversation
While browsing the code, I spotted this line that would break if the IP address was IPv6. Use the Go standard library helper to safely join a host and port, which knows how to handle IPv6 properly. Signed-off-by: Russell Bryant <rbryant@redhat.com>
elevran
approved these changes
Jun 16, 2025
yewentao256
approved these changes
Jun 16, 2025
pierDipi
pushed a commit
to pierDipi/llm-d-inference-scheduler
that referenced
this pull request
Nov 28, 2025
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While browsing the code, I spotted this line that would break if the
IP address was IPv6. Use the Go standard library helper to safely join
a host and port, which knows how to handle IPv6 properly.
Signed-off-by: Russell Bryant rbryant@redhat.com