OWNERS_ALIASES is not working with current automation#296
Merged
nirrozenbaum merged 1 commit intollm-d:mainfrom Aug 18, 2025
Merged
OWNERS_ALIASES is not working with current automation#296nirrozenbaum merged 1 commit intollm-d:mainfrom
nirrozenbaum merged 1 commit intollm-d:mainfrom
Conversation
nirrozenbaum
requested review from
elevran,
kfirtoledo,
kfswain,
nilig and
shmuelk
as code owners
elevran
approved these changes
Aug 18, 2025
Collaborator
|
seems there's no reference to aliasing in the action's repo (e.g., https://github.com/jpmcb/prow-github-actions/blob/1accfe4a8ca80422f59da41949e6ea810a7b647d/src/utils/auth.ts#L226) |
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
elevran
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current automation of the new workflow to automation owners lgtm and approval doesn't work with OWNERS_ALIASES.
revert back to use OWNERS file only.