Support for installation of inference-sim with kv-cache enabled#305
Merged
github-actions[bot] merged 1 commit intollm-d:mainfrom Aug 20, 2025
Merged
Support for installation of inference-sim with kv-cache enabled#305github-actions[bot] merged 1 commit intollm-d:mainfrom
github-actions[bot] merged 1 commit intollm-d:mainfrom
Conversation
Contributor
mayabar
commented
Aug 19, 2025
mayabar
commented
- add example of scheduler and simulator configuration to work with kv-cache
- update kind-dev-env.sh to support model names with '/'
- disable kind environment creation with both PD_ENABLED and KV_CACHE_ENABED true
mayabar
requested review from
elevran,
kfirtoledo,
kfswain,
nilig,
nirrozenbaum and
shmuelk
as code owners
kfswain
previously approved these changes
Aug 19, 2025
| - name: PD_PROMPT_LEN_THRESHOLD | ||
| value: '${PD_PROMPT_LEN_THRESHOLD}' | ||
| - name: PYTHONHASHSEED | ||
| value: "42" |
Collaborator
There was a problem hiding this comment.
Is this a Hitchhikers Guide Reference? 😂 (Just wondering why we chose 42)
Contributor
Author
There was a problem hiding this comment.
Copied from kv-cache-manager ;)
mayabar
force-pushed
the
sim-with-kvcache
branch
from
4e9026c to
5a6d867
Compare
shmuelk
requested changes
Aug 20, 2025
…cache update kind-dev-env.sh to support model names with '/' disable kind environment creation with both PD_ENABLED and KV_CACHE_ENABED true remove irrelevant comment Signed-off-by: Maya Barnea <mayab@il.ibm.com>
mayabar
force-pushed
the
sim-with-kvcache
branch
from
5a6d867 to
11a8d18
Compare
Collaborator
|
/lgtm /approve |
github-actions
bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.