fixed a bug where typos check is checking go.mod and go.sum#321
Merged
github-actions[bot] merged 1 commit intollm-d:mainfrom Aug 29, 2025
Merged
fixed a bug where typos check is checking go.mod and go.sum#321github-actions[bot] merged 1 commit intollm-d:mainfrom
github-actions[bot] merged 1 commit intollm-d:mainfrom
Conversation
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Collaborator
|
/lgtm I think llm-d uses prow now so I think this works? |
github-actions
bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
Author
|
it works 😃 it’s not pure prow like in kubernetes, it’s prow-alike github action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocking PR #320 to sync with IGW latest RC.
we should exclude go.sum and go.mod from typos check