fixed missing dependencies in makefile

[nirrozenbaum]

No description provided.

[elevran]

#322 mentions dropping pkg-config as part of fixing #286.
Did #322 only partially resolve the issue? Wondering why pkg-conf is still needed.

[elevran]

besides the above confusion on my end
/lgtm

Leaving approval to @vMaroon and/or @shmuelk

[nirrozenbaum]

adding the output before this fix per @shmuelk's request:

llm-d-inference-scheduler nirro$ make test-unit
Checking and installing development dependencies...
✅ ZeroMQ is already installed.
==== Running Unit Tests ====
go test -ldflags="-extldflags '-L/Users/nirro/dev/github.com/fork/llm-d/llm-d-inference-scheduler/lib'" -v $(echo $(go list ./... | grep -v /test/))
github.com/pebbe/zmq4: exec: "pkg-config": executable file not found in $PATH
FAIL	github.com/llm-d/llm-d-inference-scheduler/cmd/epp [build failed]
FAIL	github.com/llm-d/llm-d-inference-scheduler/pkg/plugins [build failed]
=== RUN   TestByLabelSelectorFactoryWithJSON
=== RUN   TestByLabelSelectorFactoryWithJSON/simple_matchLabels_selector
=== RUN   TestByLabelSelectorFactoryWithJSON/complex_selector_with_matchExpressions
=== RUN   TestByLabelSelectorFactoryWithJSON/empty_selector
=== RUN   TestByLabelSelectorFactoryWithJSON/matchExpressions_only
=== RUN   TestByLabelSelectorFactoryWithJSON/exists_operator
--- PASS: TestByLabelSelectorFactoryWithJSON (0.00s)
    --- PASS: TestByLabelSelectorFactoryWithJSON/simple_matchLabels_selector (0.00s)
    --- PASS: TestByLabelSelectorFactoryWithJSON/complex_selector_with_matchExpressions (0.00s)
    --- PASS: TestByLabelSelectorFactoryWithJSON/empty_selector (0.00s)
    --- PASS: TestByLabelSelectorFactoryWithJSON/matchExpressions_only (0.00s)
    --- PASS: TestByLabelSelectorFactoryWithJSON/exists_operator (0.00s)
=== RUN   TestByLabelSelectorFactoryWithInvalidJSON
=== RUN   TestByLabelSelectorFactoryWithInvalidJSON/invalid_json_syntax
=== RUN   TestByLabelSelectorFactoryWithInvalidJSON/invalid_operator
--- PASS: TestByLabelSelectorFactoryWithInvalidJSON (0.00s)
    --- PASS: TestByLabelSelectorFactoryWithInvalidJSON/invalid_json_syntax (0.00s)
    --- PASS: TestByLabelSelectorFactoryWithInvalidJSON/invalid_operator (0.00s)
=== RUN   TestByLabelSelectorFiltering
=== RUN   TestByLabelSelectorFiltering/matchLabels_-_app_nginx
=== RUN   TestByLabelSelectorFiltering/matchLabels_-_exact_match
=== RUN   TestByLabelSelectorFiltering/matchExpressions_-_In_operator
=== RUN   TestByLabelSelectorFiltering/matchExpressions_-_NotIn_operator
=== RUN   TestByLabelSelectorFiltering/matchExpressions_-_Exists_operator
=== RUN   TestByLabelSelectorFiltering/matchExpressions_-_DoesNotExist_operator
=== RUN   TestByLabelSelectorFiltering/combined_matchLabels_and_matchExpressions
=== RUN   TestByLabelSelectorFiltering/empty_selector_-_matches_all
=== RUN   TestByLabelSelectorFiltering/no_matches
--- PASS: TestByLabelSelectorFiltering (0.00s)
    --- PASS: TestByLabelSelectorFiltering/matchLabels_-_app_nginx (0.00s)
    --- PASS: TestByLabelSelectorFiltering/matchLabels_-_exact_match (0.00s)
    --- PASS: TestByLabelSelectorFiltering/matchExpressions_-_In_operator (0.00s)
    --- PASS: TestByLabelSelectorFiltering/matchExpressions_-_NotIn_operator (0.00s)
    --- PASS: TestByLabelSelectorFiltering/matchExpressions_-_Exists_operator (0.00s)
    --- PASS: TestByLabelSelectorFiltering/matchExpressions_-_DoesNotExist_operator (0.00s)
    --- PASS: TestByLabelSelectorFiltering/combined_matchLabels_and_matchExpressions (0.00s)
    --- PASS: TestByLabelSelectorFiltering/empty_selector_-_matches_all (0.00s)
    --- PASS: TestByLabelSelectorFiltering/no_matches (0.00s)
=== RUN   TestByLabelSelectorFilterEdgeCases
=== RUN   TestByLabelSelectorFilterEdgeCases/empty_pods_slice
=== RUN   TestByLabelSelectorFilterEdgeCases/nil_pods_slice
=== RUN   TestByLabelSelectorFilterEdgeCases/pods_with_nil_labels
=== RUN   TestByLabelSelectorFilterEdgeCases/pods_with_empty_labels
--- PASS: TestByLabelSelectorFilterEdgeCases (0.00s)
    --- PASS: TestByLabelSelectorFilterEdgeCases/empty_pods_slice (0.00s)
    --- PASS: TestByLabelSelectorFilterEdgeCases/nil_pods_slice (0.00s)
    --- PASS: TestByLabelSelectorFilterEdgeCases/pods_with_nil_labels (0.00s)
    --- PASS: TestByLabelSelectorFilterEdgeCases/pods_with_empty_labels (0.00s)
=== RUN   ExamplePrefillDecodeRolesInLWS
--- PASS: ExamplePrefillDecodeRolesInLWS (0.00s)
PASS
ok  	github.com/llm-d/llm-d-inference-scheduler/pkg/plugins/filter	(cached)
?   	github.com/llm-d/llm-d-inference-scheduler/pkg/plugins/pre-request	[no test files]
?   	github.com/llm-d/llm-d-inference-scheduler/pkg/plugins/profile	[no test files]
FAIL	github.com/llm-d/llm-d-inference-scheduler/pkg/plugins/scorer [build failed]
FAIL	github.com/llm-d/llm-d-inference-scheduler/pkg/scheduling/pd [build failed]
FAIL
make: *** [test-unit] Error 1

[nirrozenbaum]

@elevran see the output of the make-test command. pkg-config is required by zmq, otherwise one cannot run unit tests.

[shmuelk]

/lgtm

/approve

[elevran]

@nirrozenbaum - thanks. So it seems #322 did not fully fix #286.