Skip to content

fix: Rename config to kv-cache-utilization-scorer from kv-cache-scorer#358

Merged
github-actions[bot] merged 1 commit intollm-d:mainfrom
yankay:update-kv-cache-scorer
Sep 26, 2025
Merged

fix: Rename config to kv-cache-utilization-scorer from kv-cache-scorer#358
github-actions[bot] merged 1 commit intollm-d:mainfrom
yankay:update-kv-cache-scorer

Conversation

@yankay
Copy link
Contributor

@yankay yankay commented Sep 25, 2025

After the kubernetes-sigs/gateway-api-inference-extension#1238,
Rename config to kv-cache-utilization-scorer from kv-cache-scorer

@yankay yankay changed the title [Fix] Rename config to kv-cache-utilization-scorer from kv-cache-scorer fix: Rename config to kv-cache-utilization-scorer from kv-cache-scorer Sep 25, 2025
@yankay
Copy link
Contributor Author

yankay commented Sep 26, 2025

Thanks @nirrozenbaum
It has been changed

@nirrozenbaum
Copy link
Collaborator

Thanks @yankay 🙏🏼
can you rebase so we can merge it?

/approve
will put final stamp after rebase.

github-actions[bot]
github-actions bot previously approved these changes Sep 26, 2025
@github-actions
Copy link

Cannot approve the pull request: Error: yankay is not included in the approvers role in the OWNERS file

Co-authored-by: Nir Rozenbaum <nirro@il.ibm.com>
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@yankay yankay force-pushed the update-kv-cache-scorer branch from d394400 to 772ffa6 Compare September 26, 2025 09:34
@yankay
Copy link
Contributor Author

yankay commented Sep 26, 2025

Thanks @yankay

Thanks @nirrozenbaum
It has been changed :-)

@nirrozenbaum
Copy link
Collaborator

/lgtm
/approve

Thanks! 🙏

@github-actions github-actions bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@nirrozenbaum nirrozenbaum self-assigned this Sep 26, 2025
@github-actions github-actions bot merged commit e24e0d8 into llm-d:main Sep 26, 2025
6 checks passed
usize pushed a commit to usize/llm-d-inference-scheduler that referenced this pull request Oct 6, 2025
…llm-d#358)

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Co-authored-by: Nir Rozenbaum <nirro@il.ibm.com>
Signed-off-by: usize <mofoster@redhat.com>
usize pushed a commit to usize/llm-d-inference-scheduler that referenced this pull request Oct 8, 2025
…llm-d#358)

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Co-authored-by: Nir Rozenbaum <nirro@il.ibm.com>
Signed-off-by: usize <mofoster@redhat.com>
guygir pushed a commit to guygir/llm-d-inference-scheduler that referenced this pull request Nov 2, 2025
…llm-d#358)

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Co-authored-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants