Supports the ResponseComplete plugin#378
Merged
github-actions[bot] merged 1 commit intollm-d:mainfrom Oct 17, 2025
Merged
Conversation
learner0810
force-pushed
the
Supports-ResponseComplete-plugin
branch
from
0f77dd9 to
a204368
Compare
Collaborator
|
Thanks @learner0810, this PR lgtm. I’ll leave the final stamp for @vMaroon. /approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
learner0810
force-pushed
the
Supports-ResponseComplete-plugin
branch
from
a204368 to
858cf6e
Compare
Member
|
Looks good, thanks @learner0810! Please verify your commits then good to go. /lgtm |
github-actions
bot
added
the
lgtm
learner0810
force-pushed
the
Supports-ResponseComplete-plugin
branch
from
858cf6e to
fbe6715
Compare
Signed-off-by: learner0810 <zhongjun.li@daocloud.io>
learner0810
force-pushed
the
Supports-ResponseComplete-plugin
branch
from
fbe6715 to
1bd9198
Compare
vMaroon
reviewed
Oct 17, 2025
| } | ||
|
|
||
| // must be chat-completions request at this point, return string of entire messages | ||
| data, err := json.Marshal(request.Body.ChatCompletions.Messages) |
Member
There was a problem hiding this comment.
This will not work, but it doesn't work right now either. We'll follow-up with a PR to integrate chat-completions support.
vMaroon
approved these changes
Oct 17, 2025
github-project-automation
bot
moved this from In review
to Done
in llm-d-inference-scheduler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #375, #376