🌱 Remove legacy typo and link checker workflows by clubanderson · Pull Request #617 · llm-d/llm-d-inference-scheduler

clubanderson · 2026-02-14T05:03:30Z

Summary

Removes the old check-typos.yaml and/or md-link-check.yml caller workflows. These are replaced by AI-powered gh-aw agentic workflows (typo-checker.md and link-checker.md) deployed centrally in llm-d-infra.

The reusable workflows in llm-d-infra are kept as legacy fallback.

Test plan

Verify no CI regressions (agentic replacements handle typo/link checking)

/cc @elevran @shmuelk

github-actions · 2026-02-14T05:03:38Z

🚨 Unsigned commits detected! Please sign your commits.

For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation.

Copilot

Pull request overview

This PR removes two legacy GitHub Actions workflows for typo checking and markdown link validation. These workflows are being replaced by centrally deployed AI-powered agentic workflows (typo-checker.md and link-checker.md) in the llm-d-infra repository, as part of a broader modernization effort.

Changes:

Removed the check-typos.yaml workflow that used the crate-ci/typos action
Removed the md-link-check.yml workflow that used the lycheeverse/lychee-action

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`.github/workflows/md-link-check.yml`	Removes markdown link checker workflow that validated links in documentation
`.github/workflows/check-typos.yaml`	Removes typo checking workflow that scanned codebase for spelling errors

Comments suppressed due to low confidence (2)

.github/workflows/md-link-check.yml:1

The .lychee.toml configuration file in the repository root is now orphaned since this workflow that used it is being removed. Consider removing .lychee.toml as well, or document that it's retained for the centrally deployed agentic workflow in llm-d-infra if that's the intention.
.github/workflows/check-typos.yaml:1
The .typos.toml configuration file in the repository root is now orphaned since this workflow that used it is being removed. Consider removing .typos.toml as well, or document that it's retained for the centrally deployed agentic workflow in llm-d-infra if that's the intention.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

elevran

Thanks for the PR. A few high level comments:

kndly request to not open branches on this repo for PR's - use a fork instead. Will close this branch in a couple of days so you have time to move the changes over.
please clarify the benefit of "agentic workflows" for tasks that can be handled by regualr tool calling and would produce consistent/repeatable results (unlike LLMs).
there are some issues recently open on the repo (#621 #622 #623 #630) which seem related to the use of agentic PRs. Can you please clarify what value they provide beyond what's already reported on the issue itself (pass/fail and comments)? These would cause excessive GH notifications and emails on watched repos for each PR run. I expect agentic workflows, when run, to report directly on the PRs and not manage their own issues to track runs.

elevran · 2026-02-17T10:13:54Z

.github/workflows/check-typos.yaml

Please do not delete this file. We would like to keep running the "legacy" typos check as default, possibly monitoring how the "agentic" one performs so we can make an informed decision.

elevran · 2026-02-17T10:15:04Z

.github/workflows/copilot-setup-steps.yml

For now I prefer not to have agentic workflows run for checks that can be just as well run with deterministic tools, so no need to setup Copilot tooling just yet.

elevran · 2026-02-17T10:16:26Z

.github/workflows/link-checker.lock.yml

Q:
Do we need both the *.lock.yml file and the *.md that was used to create it in our repo?
Should we be importing actions from llm-d-infra instead of replicating the files?

This applies to all agentic workflows in the PR

elevran · 2026-02-17T10:18:33Z

.github/workflows/link-checker.md

@@ -0,0 +1,130 @@
+---
+description: |


Can you please clarify the value that you expect from running LLM to check links and/or typos, actions that can be done by deterministic tooling with equal or better success?
Since LLM output depends on prompt and is also subject to hallucenations or statistical variance, we don't want testing flakes introduced by multiple LLM runs.

elevran · 2026-02-17T10:20:56Z

.github/workflows/link-checker.md

+   - **Internal links**: verify the target file exists in the repo using `ls` or `test -f`
+   - **Anchor links**: verify the heading exists in the target file
+   - **External links**: use `curl -sL -o /dev/null -w '%{http_code}' --max-time 10` to check
+     - For external URLs that return 4xx: mark as **definitely broken**


what about 3xx errors (e.g., moved permanently, found, ...)?

elevran · 2026-02-17T10:36:20Z

test/e2e/e2e_suite_test.go

unclear how's this file change is related

elevran · 2026-02-17T10:36:48Z

.lychee.toml

ditto - should not be deleted unless we move to agentic flows.

elevran · 2026-02-17T10:37:01Z

.typos.toml

ditto - do not remove.

elevran · 2026-02-17T10:37:56Z

.typos.toml

@@ -1,17 +0,0 @@
-[default.extend-words]


Are the below words and file types exception supported in the new wrokflows?
They should support per repo configurations.

elevran · 2026-02-17T10:38:42Z

go.mod

are the go.mod/sum changes related to this PR?

elevran · 2026-02-17T10:47:46Z

nit: there seems to be a duplicate signoff message on commits:

🌱 Remove legacy typo and link checker workflows
Remove check-typos.yaml and md-link-check.yml workflows that are now
replaced by centrally deployed agentic workflows from llm-d-infra.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>

Remove orphaned workflow caller files that referenced deleted reusable workflows from llm-d-infra Signed-off-by: Andy Anderson <andy@clubanderson.com>

clubanderson · 2026-02-18T13:00:40Z

Closing in favor of a consolidated PR from fork that combines #616 and #617 (minus agentic workflows) to address review feedback. Will reopen from fork per maintainer request.

Consolidated PR replacing llm-d#616 and llm-d#617. Governance & tooling standardization: - Simplify all governance workflows to use reusable patterns - Add .pre-commit-config.yaml with standard hooks - Update Dockerfiles and Makefile.tools.mk - Update go.mod/go.sum dependencies - Standardize test imports Legacy CI cleanup: - Remove check-typos.yaml and md-link-check.yml (replaced by pre-commit) - Remove orphaned .lychee.toml and .typos.toml configs Agentic workflows: - Add typo-checker, link-checker, and upstream-monitor agentic workflows - Add copilot-setup-steps and actions-lock config - Add upstream-versions tracking doc Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com>

Copilot AI review requested due to automatic review settings February 14, 2026 05:03

github-project-automation bot added this to llm-d-inference-scheduler Feb 14, 2026

github-actions bot requested review from kfswain and shmuelk February 14, 2026 05:03

Copilot started reviewing on behalf of clubanderson February 14, 2026 05:03 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

clubanderson force-pushed the feature/remove-legacy-ci-callers branch from f705c8a to 1009370 Compare February 16, 2026 02:08

This was referenced Feb 16, 2026

[agentics] Typo Checker failed #622

Open

[agentics] Link Checker failed #623

Open

clubanderson force-pushed the feature/remove-legacy-ci-callers branch from ea40901 to 67f52f5 Compare February 17, 2026 02:41

github-actions bot mentioned this pull request Feb 17, 2026

[agentics] No-Op Runs #630

Open

elevran requested changes Feb 17, 2026

View reviewed changes

github-project-automation bot moved this to In review in llm-d-inference-scheduler Feb 17, 2026

clubanderson force-pushed the feature/remove-legacy-ci-callers branch from 8bf42c1 to d53d7c3 Compare February 17, 2026 19:53

🌱 Remove legacy typo and link checker workflows

ed0c98e

Remove orphaned workflow caller files that referenced deleted reusable workflows from llm-d-infra Signed-off-by: Andy Anderson <andy@clubanderson.com>

clubanderson force-pushed the feature/remove-legacy-ci-callers branch from d53d7c3 to ed0c98e Compare February 17, 2026 21:45

clubanderson mentioned this pull request Feb 18, 2026

🌱 Standardize governance workflows, pre-commit, and tooling #616

Closed

2 tasks

clubanderson closed this Feb 18, 2026

github-project-automation bot moved this from In review to Done in llm-d-inference-scheduler Feb 18, 2026

clubanderson mentioned this pull request Feb 18, 2026

🌱 Standardize governance workflows, pre-commit, and remove legacy CI #633

Open

3 tasks

		@@ -0,0 +1,130 @@
		---
		description: \|

Conversation

clubanderson commented Feb 14, 2026

Summary

Test plan

Uh oh!

github-actions bot commented Feb 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

elevran left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elevran commented Feb 17, 2026

Uh oh!

clubanderson commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants