Skip to content

fix: remove kustomize dependency #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gyliu513 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

fix: remove kustomize dependency #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ Documentation for developing the inference scheduler.
- [Golang] `v1.24`+
- [Docker] (or [Podman])
- [Kubernetes in Docker (KIND)]
- [Kustomize]
- [Kubectl] `v1.14`+
- [ZeroMQ]

[Make]:https://www.gnu.org/software/make/
[Golang]:https://go.dev/
[Docker]:https://www.docker.com/
[Podman]:https://podman.io/
[Kubernetes in Docker (KIND)]:https://github.com/kubernetes-sigs/kind
[Kustomize]:https://kubectl.docs.kubernetes.io/installation/kustomize/
[Kubectl]:https://kubectl.docs.kubernetes.io/installation/kubectl/
[ZeroMQ]:https://zeromq.org/

> [!NOTE]
Expand Down
10 changes: 5 additions & 5 deletions scripts/kind-dev-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ fi
set -u

# Check for required programs
for cmd in kind kubectl kustomize ${CONTAINER_RUNTIME}; do
for cmd in kind kubectl ${CONTAINER_RUNTIME}; do
if ! command -v "$cmd" &> /dev/null; then
echo "Error: $cmd is not installed or not in the PATH."
exit 1
Expand Down Expand Up @@ -232,13 +232,13 @@ fi
# CRD Deployment (Gateway API + GIE)
# ------------------------------------------------------------------------------

kustomize build deploy/components/crds-gateway-api |
kubectl kustomize deploy/components/crds-gateway-api |
kubectl --context ${KUBE_CONTEXT} apply --server-side --force-conflicts -f -

kustomize build deploy/components/crds-gie |
kubectl kustomize deploy/components/crds-gie |
kubectl --context ${KUBE_CONTEXT} apply --server-side --force-conflicts -f -

kustomize build --enable-helm deploy/components/crds-istio |
kubectl kustomize --enable-helm deploy/components/crds-istio |
kubectl --context ${KUBE_CONTEXT} apply --server-side --force-conflicts -f -

# ------------------------------------------------------------------------------
Expand All @@ -260,7 +260,7 @@ kubectl --context ${KUBE_CONTEXT} delete configmap epp-config --ignore-not-found
envsubst '$PRIMARY_PORT' < ${EPP_CONFIG} > ${TEMP_FILE}
kubectl --context ${KUBE_CONTEXT} create configmap epp-config --from-file=epp-config.yaml=${TEMP_FILE}

kustomize build --enable-helm ${KUSTOMIZE_DIR} \
kubectl kustomize --enable-helm ${KUSTOMIZE_DIR} \
| envsubst '${POOL_NAME} ${MODEL_NAME} ${MODEL_NAME_SAFE} ${EPP_NAME} ${EPP_IMAGE} ${VLLM_SIMULATOR_IMAGE} \
${PD_ENABLED} ${KV_CACHE_ENABLED} ${SIDECAR_IMAGE} ${UDS_TOKENIZER_IMAGE} ${TARGET_PORTS} \
${VLLM_REPLICA_COUNT} ${VLLM_REPLICA_COUNT_P} ${VLLM_REPLICA_COUNT_D} ${VLLM_DATA_PARALLEL_SIZE}' \
Expand Down