Skip to content

Merge Dev#96

Merged
vMaroon merged 27 commits intomainfrom
dev
May 18, 2025
Merged

Merge Dev#96
vMaroon merged 27 commits intomainfrom
dev

Conversation

@vMaroon
Copy link
Member

@vMaroon vMaroon commented May 16, 2025

Summary

  • inference-scheduler bug fixes
  • imported some upstream bug fixes
  • PD scheduler OnResponse redirects to decode OnReponse
  • CI fix
  • chore: add healthcheck workaround #93
  • switch to GitHub-actions since tekton broke

shmuelk and others added 7 commits May 15, 2025 12:58
…nd to use less constants (#92)

* config is now a plugin config. Refactored use of environment variables

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Refactored to support plugin config and added K8S plugins

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Added upstream filters and updated go comments

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Added upstream filters

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* [version bump] Promote 0.0.4 to prod, bump dev to 0.0.5

* Fixed lint error

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Use upstream environment variables to configure the upstream prefix filter

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Upfates from review. Fixed bug and renamed variables.

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Updates from review

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Updates from review

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

* Updates from review

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>

---------

Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Co-authored-by: ci-tag-bot <ci-tag-bot@example.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
…itialize build-in prefix scorer

Signed-off-by: Maya Barnea <mayab@il.ibm.com>
When both pd and decode prefix scorer are disabled - don't initialize build-in prefix scorer
[chore] Bump Upstream Import Version
@vMaroon vMaroon requested a review from clubanderson May 16, 2025 17:42
clubanderson
clubanderson previously approved these changes May 16, 2025
Copy link
Contributor

@clubanderson clubanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vMaroon
Copy link
Member Author

vMaroon commented May 16, 2025

/retest

@mayabar mayabar self-requested a review May 16, 2025 19:31
mayabar
mayabar previously approved these changes May 16, 2025
@vMaroon
Copy link
Member Author

vMaroon commented May 16, 2025

/hold

mayabar and others added 3 commits May 17, 2025 00:27
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
@vMaroon vMaroon dismissed stale reviews from mayabar and clubanderson via 6a1d726 May 16, 2025 21:40
shaneutt
shaneutt previously approved these changes May 16, 2025
clubanderson
clubanderson previously approved these changes May 16, 2025
@clubanderson
Copy link
Contributor

/retest

mayabar
mayabar previously approved these changes May 17, 2025
@vMaroon
Copy link
Member Author

vMaroon commented May 17, 2025

/retest

@clubanderson
Copy link
Contributor

/lgtm

clubanderson
clubanderson previously approved these changes May 18, 2025
@elevran
Copy link
Collaborator

elevran commented May 18, 2025

Note that the Pipeline as Code CI check can't pass since the changeset disables it. We should remove if from the list of tests expected on PRs

Co-authored-by: Etai Lev Ran <elevran@gmail.com>
@vMaroon
Copy link
Member Author

vMaroon commented May 18, 2025

@shmuelk @mayabar please follow up on comments on your merged code. The code was merged without thorough reviews due to urgency, but it would be great if you can issue/follow up on @elevran's comments.

elevran
elevran previously approved these changes May 18, 2025
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@vMaroon vMaroon merged commit f5c1192 into main May 18, 2025
2 checks passed
@vMaroon vMaroon deleted the dev branch May 20, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants