pool: Track decode blocks without parent lineage (from prefill)#347
Open
RishabhSaini wants to merge 3 commits intollm-d:mainfrom
Open
pool: Track decode blocks without parent lineage (from prefill)#347RishabhSaini wants to merge 3 commits intollm-d:mainfrom
RishabhSaini wants to merge 3 commits intollm-d:mainfrom
Conversation
Collaborator
|
I think this change is reasonable, but I have a follow-up question: after the key is properly added to the index, will the routing process perform a lookup and select the appropriate decoding node? |
Member
|
Can you verify that KVEvents are not generated after transferring KVs from prefill to decode? AFAIK the mechanism should be working. If it doesn't, then it's a bug in vLLM. |
19e051b to
357690a
Compare
Author
|
Looks like there is a race condition here when doing PD Disagg causing Prefill Pod -> ZMQ PUB -> EPP SUB (goroutine 1) -> Worker Queue 0 -> digestEvents
|
97da2cb to
e503b92
Compare
requests which have events with missing parent blocks
ce03576 to
3c7d856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in PD Disagg mode, the decode KV Cache events were dropped since their parents were generated in the Prefill pods