test: Add test and usage example for mm requests#453
test: Add test and usage example for mm requests#453sagearc wants to merge 3 commits intollm-d:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds multimodal (image) coverage to the UDS tokenizer renderer integration tests by introducing a local image fixture and new MM-specific test cases.
Changes:
- Add local llm-d logo testdata and a fixture that exposes it as a base64 data URL.
- Introduce MM model fixture and new
RenderChatCompletionMM integration tests. - Add helper for building image+text chat messages for test requests.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
services/uds_tokenizer/tests/testdata/llmd_logo.png |
Adds a local image asset used by MM tests. |
services/uds_tokenizer/tests/test_renderer.py |
Adds MM request helpers and new MM integration tests (features + determinism). |
services/uds_tokenizer/tests/conftest.py |
Adds MM model fixture and base64 data URL fixture backed by local testdata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@delavet Introducing a dockerfile maybe complex to run this program, how about follow other demos like |
Perhaps you’re right—this would make verification simpler. However, I usually do verify in Kubernetes environments, so I may consider submitting a PR to include Kubernetes deployment-related content. Thank you for your feedback! I'll approve this for now. @sagearc What do you think? Perhaps we can merge this PR now? |
|
@sagearc +1 to land the test first, we can always have follow up PRs. |
|
@sagearc Thanks, I think we can merge this right after conflicts being resolved |
|
Opened this PR to update all examples to use the tokenization service: |
7fe0277 to
0a019ba
Compare
Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
0a019ba to
5845ba6
Compare
Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
review fixes from #428
Added the example from #280 and mm test
Closes #451, Closes #452