ci: Wire fs_backend Python tests into CI#578
Open
albertoperdomo2 wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
cc: @kfirtoledo this PR might help both the CI tests and the issue you mentioned in the storage events emission test file. |
03e8b49 to
b93b2bb
Compare
Contributor
Author
|
cc: @yankay |
Collaborator
|
Nice work! Thanks @albertoperdomo2! |
3d61ed2 to
f092905
Compare
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
f092905 to
2f41570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CI coverage for the CPU-safe subset of the llm-d fs backend Python tests. The root
unit-testtarget now also runs a dedicatedunit-test-fs-backend-cputarget, which collects all tests underkv_connectors/llmd_fs_backend/tests/cpu/, a directory reserved for tests that do not require CUDA, vLLM, NIXL, or compiled storage extensions. New CPU-safe tests can be added by dropping files into that directory.The fs backend pytest harness now supports a
no_cuda_requiredmarker so CPU-safe tests can bypass the existing autouse CUDA setup/teardown while preserving CUDA requirements for the rest of the suite. Python test dependencies for this lightweight path are kept inkv_connectors/llmd_fs_backend/tests/requirements-cpu.txt, and CI installs them before runningmake unit-test.Test
Validated with:
Related Issues