Skip to content

ci: Wire fs_backend Python tests into CI#578

Open
albertoperdomo2 wants to merge 3 commits into
llm-d:mainfrom
albertoperdomo2:ci/fs-backend-cpu-tests
Open

ci: Wire fs_backend Python tests into CI#578
albertoperdomo2 wants to merge 3 commits into
llm-d:mainfrom
albertoperdomo2:ci/fs-backend-cpu-tests

Conversation

@albertoperdomo2
Copy link
Copy Markdown
Contributor

@albertoperdomo2 albertoperdomo2 commented May 7, 2026

Summary

Adds CI coverage for the CPU-safe subset of the llm-d fs backend Python tests. The root unit-test target now also runs a dedicated unit-test-fs-backend-cpu target, which collects all tests under kv_connectors/llmd_fs_backend/tests/cpu/, a directory reserved for tests that do not require CUDA, vLLM, NIXL, or compiled storage extensions. New CPU-safe tests can be added by dropping files into that directory.

The fs backend pytest harness now supports a no_cuda_required marker so CPU-safe tests can bypass the existing autouse CUDA setup/teardown while preserving CUDA requirements for the rest of the suite. Python test dependencies for this lightweight path are kept in kv_connectors/llmd_fs_backend/tests/requirements-cpu.txt, and CI installs them before running make unit-test.

Test

Validated with:

make unit-test-fs-backend-cpu

Related Issues

@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2026
@albertoperdomo2
Copy link
Copy Markdown
Contributor Author

cc: @kfirtoledo this PR might help both the CI tests and the issue you mentioned in the storage events emission test file.

@albertoperdomo2 albertoperdomo2 force-pushed the ci/fs-backend-cpu-tests branch from 03e8b49 to b93b2bb Compare May 20, 2026 10:46
@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2026
@albertoperdomo2 albertoperdomo2 marked this pull request as ready for review May 20, 2026 10:57
@albertoperdomo2
Copy link
Copy Markdown
Contributor Author

cc: @yankay

@yankay
Copy link
Copy Markdown
Collaborator

yankay commented May 21, 2026

Nice work!
Only One ask : make unit-test now implicitly needs Python deps — Go-only devs will hit ModuleNotFoundError locally. Could we wrap pytest in a venv like uds-tokenizer-install-deps (Makefile:115-135) does? Then it stays self-contained and the CI pip install step goes away.

Thanks @albertoperdomo2!

@github-actions github-actions Bot added the lgtm Looks good to me, indicates that a PR is ready to be merged. label May 21, 2026
@albertoperdomo2 albertoperdomo2 force-pushed the ci/fs-backend-cpu-tests branch from 3d61ed2 to f092905 Compare May 27, 2026 12:32
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
@albertoperdomo2 albertoperdomo2 force-pushed the ci/fs-backend-cpu-tests branch from f092905 to 2f41570 Compare May 28, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Looks good to me, indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants