Standardize real model usage across all E2E tests#1373
Closed
mayabar wants to merge 11 commits into
Closed
Conversation
github-actions
Bot
added
kind/cleanup
size/L
mayabar
marked this pull request as draft
May 27, 2026 12:13
mayabar
changed the title
…Render Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
…i-modal requests Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
mayabar
force-pushed
the
update-e2e-model-names
branch
from
May 28, 2026 14:29
fad358e to
c45e5a8
Compare
Contributor
Author
|
Closing this PR in favor of #1601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Currently, different parts of the E2E tests use different models. Some use real HuggingFace models, e.g.
Qwen/Qwen2-0.5BorQwen/Qwen3-32B, and some places usemodel="food-review".The E2E test uses a simulator as the backend, and its latest version (v0.9.0) utilizes a vLLM render that expects real model names.
Since the specific model used doesn't impact the test logic, standardizing on a single model across all tests will make it much easier to manage the render sidecar.
This PR updates all tests to use
Qwen/Qwen2.5-1.5B-Instruct, which was chosen because it supports both simple text requests and multi-modal messages.Fixes #1374
Release note (write
NONEif no user-facing change):