-
Notifications
You must be signed in to change notification settings - Fork 292
Codeowners based ownership #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
a2f270f
8e7cee9
2c7a3a3
e08a465
1884d17
7c5ac6c
2756f0c
18f8695
da8c560
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Fails a required check while a hold label is present, so /hold (label `hold`) | ||
| # and the release-branch auto-hold (label `do-not-merge/hold`) block | ||
| # GitHub-native auto-merge. Re-runs on label changes. | ||
|
|
||
| name: Hold gate | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize, labeled, unlabeled] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| hold: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Block merge while held | ||
| if: contains(github.event.pull_request.labels.*.name, 'hold') || contains(github.event.pull_request.labels.*.name, 'do-not-merge/hold') | ||
| run: | | ||
| echo "::error::A hold label is present (hold or do-not-merge/hold). Remove it (/hold cancel) to allow merge." | ||
| exit 1 |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # See https://help.github.com/articles/about-codeowners/ | ||
| # for more info about the CODEOWNERS file. | ||
| # | ||
| # Order matters: for any path, the last matching pattern wins (its owners | ||
| # fully replace, not extend, the owners of earlier matches). Each path's | ||
| # owners are auto-requested for review on a touching PR and required by | ||
| # branch protection on main and release-* branches. | ||
| # | ||
| # Project leadership and team membership are recorded in /LEADS.md. | ||
|
|
||
| # Default — every path falls back to the maintainers team. Each component below | ||
| # also lists the team so a maintainer can approve, while named owners are | ||
| # auto-requested for review on their paths. | ||
| * @llm-d/router-maintainers | ||
|
|
||
| # Flow control framework + plugins | ||
| /pkg/epp/flowcontrol/ @LukeAVanDrie @shmuelk @llm-d/router-maintainers | ||
| /pkg/epp/framework/plugins/flowcontrol/ @LukeAVanDrie @shmuelk @llm-d/router-maintainers | ||
|
|
||
| # Envoy ext_proc message layer | ||
| /pkg/common/envoy/ @shmuelk @llm-d/router-maintainers | ||
|
|
||
| # EPP configuration: loading logic and API types | ||
| /pkg/epp/config/ @shmuelk @llm-d/router-maintainers | ||
| /apix/config/ @shmuelk @llm-d/router-maintainers | ||
|
|
||
| # Proxy sidecar | ||
| /cmd/pd-sidecar/ @shmuelk @llm-d/router-maintainers | ||
| /pkg/sidecar/ @shmuelk @llm-d/router-maintainers | ||
|
|
||
| # SLO + latency-prediction subsystem | ||
| /pkg/epp/framework/plugins/scheduling/filter/sloheadroomtier/ @kaushikmitr @llm-d/router-maintainers | ||
| /pkg/epp/framework/plugins/scheduling/filter/prefixcacheaffinity/ @kaushikmitr @llm-d/router-maintainers | ||
| /pkg/epp/framework/plugins/scheduling/scorer/latency/ @kaushikmitr @llm-d/router-maintainers | ||
| /pkg/epp/framework/plugins/requestcontrol/admitter/latencyslo/ @kaushikmitr @llm-d/router-maintainers | ||
| /pkg/epp/framework/plugins/requestcontrol/dataproducer/predictedlatency/ @kaushikmitr @llm-d/router-maintainers | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we pls add @zetxqx as an owner to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
| # Prefix cache | ||
| /pkg/epp/framework/plugins/scheduling/scorer/prefix/ @liu-cong @vMaroon @llm-d/router-maintainers | ||
| /pkg/epp/framework/plugins/requestcontrol/dataproducer/approximateprefix/ @liu-cong @vMaroon @llm-d/router-maintainers | ||
| /pkg/epp/framework/plugins/requestcontrol/dataproducer/preciseprefixcache/ @bongwoo-bak @vMaroon @llm-d/router-maintainers | ||
|
|
||
| # Tokenization | ||
| /pkg/epp/framework/plugins/requestcontrol/dataproducer/tokenizer/ @vMaroon @liu-cong @sagearc @llm-d/router-maintainers | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Leadership | ||
|
|
||
| Project leadership for llm-d-router. | ||
|
|
||
| ## Chair | ||
|
|
||
| Responsible for the project's technical direction and overall health, and its | ||
| representative on the llm-d Technical Oversight Committee. Sets release themes, | ||
| approves design proposals for large features, grows the contributor ladder, and | ||
| is the final escalation point for technical disputes. | ||
|
|
||
| - @nilig | ||
| - @ahg-g | ||
|
|
||
| ## Maintainers | ||
|
|
||
| Members of the [`@llm-d/router-maintainers`](https://github.com/orgs/llm-d/teams/router-maintainers) | ||
| team. Maintainers are the default code owner for every path and may review and | ||
| approve changes across the repository. | ||
|
|
||
| - @ahg-g | ||
| - @elevran | ||
| - @vMaroon | ||
| - @liu-cong | ||
|
|
||
| Per-component ownership is defined in | ||
| [CODEOWNERS](CODEOWNERS) and enforced by GitHub branch | ||
| protection. | ||
|
vMaroon marked this conversation as resolved.
|
||
|
|
||
| ## Release managers | ||
|
|
||
| Members of the [`@llm-d/router-release-managers`](https://github.com/orgs/llm-d/teams/router-release-managers) | ||
| team. Tag protection on `refs/tags/v*` restricts who can push release tags to | ||
| this team. | ||
|
|
||
| - @llm-d/router-release-managers | ||
|
|
||
| ## Emeritus | ||
|
|
||
| Former maintainers, with thanks for their contributions. | ||
|
|
||
| - @kfswain | ||
| - @nirrozenbaum | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about /pkg/epp/framework/interface/flowcontrol/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done