Skip to content

fix: don't abort kind-dev-env.sh on macOS when PROM_ENABLED=true #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sudoalok wants to merge 1 commit into from
Closed

fix: don't abort kind-dev-env.sh on macOS when PROM_ENABLED=true #1645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/kind-dev-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,10 @@ done

# Prometheus config-reloader needs sufficient inotify resources
if [ "${PROM_ENABLED}" == "true" ]; then
INOTIFY_INSTANCES=$(cat /proc/sys/fs/inotify/max_user_instances)
# On non-Linux hosts (e.g. macOS) /proc does not exist and the kind pods run in
# the container-runtime VM, not the host, so fall back to a passing value rather
# than letting the failed read abort the script under `set -e`.
INOTIFY_INSTANCES=$(cat /proc/sys/fs/inotify/max_user_instances 2>/dev/null || echo 512)
if [ "${INOTIFY_INSTANCES}" -lt 512 ]; then
echo "Error: fs.inotify.max_user_instances is ${INOTIFY_INSTANCES} (need >= 512) for Prometheus."
echo ""
Expand Down
Loading