feat(standalone): use typed labels.Selector for endpoint selector#1701
Merged
Conversation
Contributor
|
🚨 Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
shichaooutlook
force-pushed
the
feat/typed-endpoint-selector
branch
5 times, most recently
from
June 22, 2026 07:42
e4d280d to
f3b8068
Compare
Replace the string-based --endpoint-selector flag with Kubernetes-native labels.Selector to support set-based label expressions (e.g., 'env in (prod,staging),tier!=frontend', 'key,!deprecated') in standalone mode. - EndpointSelector type: string -> labels.Selector - Complete(): parse flag string via labels.Parse() - EndpointPool.Selector: map[string]string -> labels.Selector - PoolLabelsMatch simplified with native Selector.Matches() - podResyncAll passes Selector directly to K8s client - All callers and tests updated for new type Signed-off-by: shichaooutlook <shichao.outlook@gmail.com>
shichaooutlook
force-pushed
the
feat/typed-endpoint-selector
branch
from
June 23, 2026 01:06
f3b8068 to
64b4b76
Compare
ahg-g
approved these changes
Jun 27, 2026
ahg-g
enabled auto-merge (squash)
June 27, 2026 10:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the string-based --endpoint-selector flag with Kubernetes-native labels.Selector to support set-based label expressions (e.g., env in (prod,staging),tier!=frontend, key,!deprecated) in
standalone mode.
Motivation