chore: switch default vllm port from 8001 to 8200 for sidecar#1723
Merged
Conversation
- remove explicitly config to use 8200 in deployment and test - keep local dev test with 8001 Signed-off-by: Wen Zhou <wenzhou@redhat.com>
github-actions
Bot
added
size/S
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the sidecar proxy’s default upstream vLLM port to align with the project’s deployment manifests (8200), reducing the need to explicitly pass --vllm-port in standard deployments while preserving the ability to override the port for local/dev scenarios.
Changes:
- Switch sidecar default vLLM port from
8001to8200. - Remove explicit
--vllm-port=8200/-vllm-port=8200arguments from deployment and sidecar test manifests (relying on the new default). - Adjust unit test YAML expectations to explicitly set
vllm-port: 8001where a non-default override is desired.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/sidecar/proxy/options.go |
Changes the default vLLM port used by the sidecar proxy to 8200. |
pkg/sidecar/proxy/options_test.go |
Updates test YAML/expectations to use an explicit non-default vLLM port (8001) where tests validate override behavior. |
deploy/components/vllm-decode/deployment.yaml |
Removes redundant --vllm-port=8200 from the routing sidecar args, relying on the new default. |
deploy/environments/dev/p-d/patch-decode.yaml |
Drops explicit --vllm-port=8200 from the dev patch overlay. |
deploy/environments/dev/e-pd/patch-decode.yaml |
Drops explicit --vllm-port=8200 from the dev patch overlay. |
deploy/environments/dev/e-p-d/patch-decode.yaml |
Drops explicit --vllm-port=8200 from the dev patch overlay. |
test/sidecar/config/nixl/qwen-decoder-pod.yaml |
Removes explicit -vllm-port=8200 from the test pod config so it uses the default. |
shmuelk
approved these changes
Jun 23, 2026
vMaroon
approved these changes
Jun 23, 2026
zdtsw
added a commit
to zdtsw/llm-d
that referenced
this pull request
Jul 26, 2026
- llm-d-router disagg sidecar now defaults --vllm-port to 8200 (llm-d/llm-d-router#1723), making the explicit flag redundant Signed-off-by: Wen Zhou <wenzhou@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release note (write
NONEif no user-facing change):