Skip to content

feat: Enable the disabling of feature gates that are by default on/active#1728

Merged
ahg-g merged 4 commits into
llm-d:mainfrom
shmuelk:ext-feature-gate
Jun 25, 2026
Merged

feat: Enable the disabling of feature gates that are by default on/active#1728
ahg-g merged 4 commits into
llm-d:mainfrom
shmuelk:ext-feature-gate

Conversation

@shmuelk

@shmuelk shmuelk commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
As experimental features graduate to standard features, there will be those that for various reasons want to be able to disable such features. To date the feature flags are a simple list that enables all features in the list in the configuration file.

This PR does the following:

  1. Extends the items in the feature flags array in the configuration to optionally be of the form gate=boolean-value where boolean-value is one of t,f,true, false,1,0 (in any case)
  2. Provides the ability to specify default values for feature flags. Until now the default value for all feature flags was false. Now a default value of true can eb provided to automatically enable features.

With this PR, the graduation of the flow control feature for example, is as simple as changing:

loader.RegisterFeatureGate(flowcontrol.FeatureGate, false)

to

loader.RegisterFeatureGate(flowcontrol.FeatureGate, true)

thus changing the default value of the flow control feature gate to true.

NOTE: This PR removes the deprecated feature flag dayaLayer that was used to enable the new data layer. This feature gate was dprecated in llm-d-router 0.8.0

Which issue(s) this PR fixes:

Fixes #1680

Release note (write NONE if no user-facing change):

- The deprecated dayaLayer feature gate has been removed. It has not been needed since llm-d-router 0.8.0
- Feature gates can now be disabled in the featureGates section of the configuration file, with the syntax gate=false

shmuelk added 4 commits June 23, 2026 18:29
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
@shmuelk
shmuelk requested a review from a team as a code owner June 23, 2026 16:25
@shmuelk
shmuelk requested review from liu-cong and vMaroon June 23, 2026 16:25
@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2026
@ahg-g
ahg-g merged commit 592da02 into llm-d:main Jun 25, 2026
30 checks passed
ahg-g pushed a commit that referenced this pull request Jun 26, 2026
Signed-off-by: llm-d-router-release-notes[bot] <287676111+llm-d-router-release-notes[bot]@users.noreply.github.com>
Co-authored-by: llm-d-router-release-notes[bot] <287676111+llm-d-router-release-notes[bot]@users.noreply.github.com>
@shmuelk
shmuelk deleted the ext-feature-gate branch July 15, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add opt-out mechanism for Flow Control when it graduates to default-on

2 participants