Add OTel span for picker in scheduling pipeline#1732
Closed
chinmaychahar wants to merge 2 commits into
Closed
Conversation
github-actions
Bot
added
the
size/L
Contributor
|
🚨 Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
Signed-off-by: chinmaychahar <chinmay.cc.06@gmail.com>
chinmaychahar
force-pushed
the
add-picker-span
branch
from
June 24, 2026 02:46
dec1ab9 to
a9cbdb2
Compare
Closed
Collaborator
|
this is addressed by #1708 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pick_endpointsspan around the picker plugin execution inrunPickerPlugin, following the convention from observability: standardize OTel service, scope, and span naming #1565 (score_prefix_cache,pick_pd_profile)llm_d.epp.picker.candidate_endpoints,llm_d.epp.picker.selected_endpoints,gen_ai.request.model,gen_ai.request.idtracerScopeconstant (llm-d-router/pkg/epp/scheduling) withtrace.WithSpanKind(trace.SpanKindInternal)Fixes #1694 (sub-task of #1483)