fix: base release-notes assembly branch on main to exclude unrelated diffs#1827
Merged
Merged
Conversation
…diffs The workflow previously created its branch from the tagged commit. When the tag diverged from main HEAD, the PR diff included unrelated changes (e.g. hack/push-chart.sh in llm-d#1688). Split the script into three phases: 1. Read fragments from the tagged commit (preserves the guard against post-tag fragments). 2. Fetch and branch from origin/main so the PR only diffs release-notes files against main. 3. Apply changes and remove only the fragments that exist on main. Signed-off-by: Cong Liu <conliu@google.com>
github-actions
Bot
added
the
size/M
Signed-off-by: Cong Liu <conliu@google.com>
Member
Author
Signed-off-by: Cong Liu <conliu@google.com>
Signed-off-by: Cong Liu <conliu@google.com>
ahg-g
approved these changes
Jun 27, 2026
abdallahsamabd
pushed a commit
to abdallahsamabd/llm-d-inference-scheduler
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hack/push-chart.shin docs: assemble release notes for v0.9.0 #1688).origin/main— the PR now only contains release-notes file changes, not release-branch-specific diffs.RELEASE-NOTES.mdand remove only the fragments that exist on main.v0.9.0-rc.1) since release notes should only be assembled for final releases.Test plan
Simulated the fixed workflow locally against the v0.9.0 tag (which lives on a release branch that diverges from main):
origin/main, not the tagged commit.RELEASE-NOTES.mdis staged — no unrelated files (e.g.hack/push-chart.sh) appear in the diff.-fguard.if: ${{ !contains(github.ref_name, '-rc') }}condition on the job.