Skip to content

[wip] ci: Remove obsolete Prow GitHub Actions integration#2114

Draft
hickeyma wants to merge 1 commit into
llm-d:mainfrom
hickeyma:ci-remove-prow
Draft

[wip] ci: Remove obsolete Prow GitHub Actions integration#2114
hickeyma wants to merge 1 commit into
llm-d:mainfrom
hickeyma:ci-remove-prow

Conversation

@hickeyma

@hickeyma hickeyma commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes the prow-github.yml workflow and its .prowlabels.yaml config. Prow's chat ops commands are superseded in this repo by CODEOWNERS, native GitHub approvals and by in-repo pull_request_target workflows: pr-kind-label.yaml already covers /kind and /area and /milestone in #2113. pr-hold-gate.yml already gates merges on the hold label without needing Prow to apply it.

.prowlabels.yaml isn't used anywhere else in the repo.

This removes Prow's extended /assign behavior for non-members which has no native replacement. Accepted per the RFC #956 discussions: "non-members should comment interest and have a maintainer assign directly".

Note for reviewers: I can't confirm from here whether prow-execute is a required branch protection status check on main because need maintainer access. Please confirm/clear this in branch protection settings before merging.

Do NOT merge until #2113 and #2157 are merged as it depends on the labels to be available.

/cc @elevran

Which issue(s) this PR fixes:
Part of #956

Release note (write NONE if no user-facing change):

NONE

Delete .github/workflows/prow-github.yml and its .prowlabels.yaml
config. Prow's issue/PR chat ops commands are superseded by
CODEOWNERS, native GitHub approvals and by in-repo
pull_request_target workflows: pr-kind-label.yaml already covers
/kind and /area and /milestone in llm-d#2113. pr-hold-gate.yml
already gates merges on the hold label without needing Prow to
apply it.

This drops Prow's non-member /assign extension which has no
native equivalent. The accepted workaround is commenting interest
and having a maintainer assign manually.

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Copilot AI review requested due to automatic review settings July 21, 2026 11:38
@hickeyma
hickeyma requested a review from a team as a code owner July 21, 2026 11:38
@hickeyma
hickeyma requested review from liu-cong and vMaroon July 21, 2026 11:38
@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup labels Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the legacy Prow GitHub Actions integration from llm-d Router’s CI configuration, relying instead on native GitHub approvals/CODEOWNERS and the existing in-repo label/hold workflows.

Changes:

  • Delete the .github/workflows/prow-github.yml workflow that ran jpmcb/prow-github-actions for slash-command chatops.
  • Delete the unused .prowlabels.yaml label config file.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.prowlabels.yaml Removes the Prow label-definition config (no remaining in-repo references found).
.github/workflows/prow-github.yml Removes the issue_comment-driven Prow chatops workflow and its prow-execute job.

@hickeyma
hickeyma marked this pull request as draft July 23, 2026 10:30
@hickeyma hickeyma changed the title ci: Remove obsolete Prow GitHub Actions integration [wip] ci: Remove obsolete Prow GitHub Actions integration Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants