feat: add new --model-server-port to replace --vllm-port#2142
Merged
Conversation
- disagg-sidecar expose vllm specific flag name which should be model server neutral. add --model-server-port to replace --vllm-port which stays as a deprecated alias until final removal. - update usage text on --data-parallel-size Signed-off-by: Wen Zhou <wenzhou@redhat.com>
github-actions
Bot
added
kind/feature
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the pd-sidecar port flag/model configuration vendor-neutral by introducing --model-server-port as the preferred flag and keeping --vllm-port as a deprecated alias, while updating related help text and YAML configuration support.
Changes:
- Add
--model-server-portand migrate existing--vllm-portusage viaComplete(), marking--vllm-portdeprecated. - Extend YAML configuration to accept
model-server-port(while continuing to acceptvllm-port). - Update validation error messages and add tests for the new flag and YAML key.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/sidecar/proxy/options.go | Adds the new flag/YAML key and migration logic; updates DecoderURL computation and validation messaging. |
| pkg/sidecar/proxy/options_test.go | Updates port validation expectations and adds tests for migration/YAML handling of the new key. |
Comment on lines
+670
to
676
| // If both keys may be present, Complete() resolves precedence: modelServerPort wins. | ||
| if cfg.ModelServerPort != 0 && !opts.isFlagSet(modelServerPort) { | ||
| opts.modelServerPort = strconv.Itoa(cfg.ModelServerPort) | ||
| } | ||
| if cfg.VLLMPort != 0 && !opts.isFlagSet(vllmPort) { | ||
| opts.vllmPort = strconv.Itoa(cfg.VLLMPort) | ||
| } |
Comment on lines
+1160
to
+1169
| func TestModelServerPortYAML(t *testing.T) { | ||
| opts, testPFlagSet := newTestOptions(t) | ||
| yaml := "{model-server-port: 8203}" | ||
| setFlag(t, testPFlagSet, inlineConfiguration, &yaml) | ||
| require.NoError(t, testPFlagSet.Parse(nil)) | ||
|
|
||
| require.NoError(t, opts.Complete()) | ||
| require.NoError(t, opts.Validate()) | ||
| require.Equal(t, "http://localhost:8203", opts.DecoderURL.String()) | ||
| } |
github-actions
Bot
added
kind/feature
elevran
reviewed
Jul 24, 2026
- update test and config which still set to old --vllm-port to new flag Signed-off-by: Wen Zhou <wenzhou@redhat.com>
- old --vllm-port set as flag should override model-server-port in Yaml - wording fix Signed-off-by: Wen Zhou <wenzhou@redhat.com>
github-actions
Bot
added
size/L
shmuelk
approved these changes
Jul 26, 2026
elevran
approved these changes
Jul 26, 2026
elevran
pushed a commit
that referenced
this pull request
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
ref ##2039
Release note (write
NONEif no user-facing change):cc @rahulgurnani