fix: flowcontrol - finalize requests during shutdown#2156
Merged
LukeAVanDrie merged 2 commits intoJul 23, 2026
Merged
Conversation
fixes llm-d#2099 Signed-off-by: nicole-lihui <nicole.li@daocloud.io>
nicole-lihui
requested review from
a team,
LukeAVanDrie and
shmuelk
as code owners
July 23, 2026 10:29
github-actions
Bot
added
size/M
LukeAVanDrie
approved these changes
Jul 23, 2026
LukeAVanDrie
left a comment
LukeAVanDrie
left a comment
Contributor
There was a problem hiding this comment.
lgtm, thanks @nicole-lihui!
| case <-reqCtx.Done(): | ||
| // Asynchronous Finalization (Controller-initiated): | ||
| // The request Context expired (Cancellation/TTL) while the item was being processed. | ||
| if fc.parentCtx.Err() != nil { |
Contributor
There was a problem hiding this comment.
Thanks for making this deterministic; good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Finalizes requests that race with Flow Controller shutdown instead of leaving them stranded until request TTL or client cancellation.
Shutdown outcomes preserve the distinction between rejected requests and requests evicted from the queue.
Which issue(s) this PR fixes:
Fixes #2099
Release note (write
NONEif no user-facing change):