-
Notifications
You must be signed in to change notification settings - Fork 292
ci: add /kind, /area, /milestone label sync for issues #2157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hickeyma
wants to merge
5
commits into
llm-d:main
Choose a base branch
from
hickeyma:ci-add-labels-issues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+152
−8
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8663551
ci: add /kind, /area, /milestone label sync for issues
hickeyma 4e776c7
Potential fix for pull request finding
hickeyma 49d0b18
ci: validate kind/area labels before removing existing ones
hickeyma 7a9e6cb
ci: no-op PR kind sync when no /kind directive
hickeyma 6c7029d
ci: escape body text in label-sync workflow warnings
hickeyma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| name: Apply kind/area labels and milestone from issue body | ||
|
|
||
| on: | ||
| issues: | ||
| types: [opened, edited] | ||
|
|
||
| jobs: | ||
| kind-labels: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| issues: write | ||
| steps: | ||
| - name: Sync kind labels | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| ISSUE_BODY: ${{ github.event.issue.body }} | ||
| ISSUE_NUMBER: ${{ github.event.issue.number }} | ||
| REPO: ${{ github.repository }} | ||
| run: | | ||
| # Escape percent sequences before echoing body derived text into a | ||
| # ::warning:: so it cannot forge additional workflow commands. | ||
| esc() { local s=$1; s=${s//'%'/%25}; s=${s//$'\r'/%0D}; s=${s//$'\n'/%0A}; printf '%s' "$s"; } | ||
|
|
||
| # Extract /kind values from issue body. Absence of a directive is a no-op | ||
| # to avoid wiping kind/* labels set by maintainers through the UI. | ||
| kinds=$(printf '%s' "$ISSUE_BODY" | tr -d '\r' | sed -n 's|^/kind[[:space:]][[:space:]]*||p' | sed 's|[[:space:]]*$||' | sed '/^$/d' | sort -u) | ||
| [ -z "$kinds" ] && exit 0 | ||
|
|
||
| # Validate every requested label before mutating. Removing first and | ||
| # failing to add a mistyped label would leave the issue with no kind/*. | ||
| existing=$(gh label list --repo "$REPO" --limit 200 --json name -q '.[].name') | ||
| unknown=$(printf '%s\n' "$kinds" | while IFS= read -r kind; do | ||
| printf '%s\n' "$existing" | grep -qxF "kind/$kind" || printf "kind/%s " "$kind" | ||
| done) | ||
| if [ -n "$unknown" ]; then | ||
| echo "::warning::Unknown label(s) $(esc "${unknown% }"), skipping kind sync" | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Remove existing kind/* labels | ||
| gh issue view "$ISSUE_NUMBER" --repo "$REPO" --json labels \ | ||
| -q '.labels[].name | select(startswith("kind/"))' | \ | ||
| while IFS= read -r label; do | ||
| gh issue edit "$ISSUE_NUMBER" --repo "$REPO" --remove-label "$label" || echo "::warning::Failed to remove label '$(esc "$label")'" | ||
| done | ||
|
|
||
| printf '%s\n' "$kinds" | \ | ||
| while IFS= read -r kind; do | ||
| gh issue edit "$ISSUE_NUMBER" --repo "$REPO" --add-label "kind/$kind" || \ | ||
| echo "::warning::Label 'kind/$(esc "$kind")' not found in repository" | ||
| done | ||
|
|
||
| - name: Set area labels | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| ISSUE_BODY: ${{ github.event.issue.body }} | ||
| ISSUE_NUMBER: ${{ github.event.issue.number }} | ||
| REPO: ${{ github.repository }} | ||
| run: | | ||
| # Escape percent sequences before echoing body derived text into a | ||
| # ::warning:: so it cannot forge additional workflow commands. | ||
| esc() { local s=$1; s=${s//'%'/%25}; s=${s//$'\r'/%0D}; s=${s//$'\n'/%0A}; printf '%s' "$s"; } | ||
|
|
||
| # Absence of a directive is a no-op. Area labels are also set by | ||
| # maintainers through the UI and clearing here would wipe those. | ||
| areas=$(printf '%s' "$ISSUE_BODY" | tr -d '\r' | sed -n 's|^/area[[:space:]][[:space:]]*||p' | \ | ||
| sed 's|[[:space:]]*$||' | sed '/^$/d' | sort -u) | ||
| [ -z "$areas" ] && exit 0 | ||
|
|
||
| existing=$(gh label list --repo "$REPO" --limit 200 --json name -q '.[].name') | ||
| unknown=$(printf '%s\n' "$areas" | while IFS= read -r area; do | ||
| printf '%s\n' "$existing" | grep -qxF "area/$area" || printf "area/%s " "$area" | ||
| done) | ||
| if [ -n "$unknown" ]; then | ||
| echo "::warning::Unknown label(s) $(esc "${unknown% }"), skipping area sync" | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Remove existing area/* labels | ||
| gh issue view "$ISSUE_NUMBER" --repo "$REPO" --json labels \ | ||
| -q '.labels[].name | select(startswith("area/"))' | \ | ||
| while IFS= read -r label; do | ||
| gh issue edit "$ISSUE_NUMBER" --repo "$REPO" --remove-label "$label" || echo "::warning::Failed to remove label '$(esc "$label")'" | ||
| done | ||
|
|
||
| printf '%s\n' "$areas" | \ | ||
| while IFS= read -r area; do | ||
| gh issue edit "$ISSUE_NUMBER" --repo "$REPO" --add-label "area/$area" || \ | ||
| echo "::warning::Label 'area/$(esc "$area")' not found in repository" | ||
| done | ||
|
|
||
| - name: Set milestone | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| ISSUE_BODY: ${{ github.event.issue.body }} | ||
| ISSUE_NUMBER: ${{ github.event.issue.number }} | ||
| REPO: ${{ github.repository }} | ||
| run: | | ||
| # Escape percent sequences before echoing body derived text into a | ||
| # ::warning:: so it cannot forge additional workflow commands. | ||
| esc() { local s=$1; s=${s//'%'/%25}; s=${s//$'\r'/%0D}; s=${s//$'\n'/%0A}; printf '%s' "$s"; } | ||
|
|
||
| # Use the last /milestone directive in the issue body | ||
| milestone=$(printf '%s' "$ISSUE_BODY" | tr -d '\r' | sed -n 's|^/milestone[[:space:]][[:space:]]*||p' | \ | ||
| sed 's|[[:space:]]*$||' | sed '/^$/d' | tail -n 1) | ||
| [ -z "$milestone" ] && exit 0 | ||
| gh issue edit "$ISSUE_NUMBER" --repo "$REPO" --milestone "$milestone" || \ | ||
| echo "::warning::Milestone '$(esc "$milestone")' not found in repository" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
types: [opened, edited]omitsreopened, which pr-kind-label.yaml includes for the same trigger. If reopening an issue can leave a stale label state, add reopened for parity; otherwise fine as is.