chore: rename internal/saturation to internal/saturationv1#1450
Open
mamy-CS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Collaborator
|
@mamy-CS saturationv1 is no longer the default; this code should be removed. |
Collaborator
Author
Yes, I was going to make it easier for the removal by explicitly renaming it. The v1 removal tracker is here, #1441) Although v1 is still going to stay selectable in v0.9 per the issue tracker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1402 (Section 4 of 7: resolve the saturation package-name collision)
Proposed Changes
internal/saturation→internal/saturationv1(3 files moved, byte-identical except thepackagedeclaration)collector/replica_metrics.go,engines/pipeline/enforcer.go,engines/saturation/engine.go): import paths + 6saturation.X→saturationv1.Xreferencesengine.goat its tracking issue (Track: deprecate & remove the V1 (percentage-based) saturation analyzer #1441) instead of a vague standalone lineWhy
internal/saturation(V1 analyzer) andinternal/engines/saturation(the Engine) were bothpackage saturation. Becauseengine.go(itselfpackage saturation) imported the V1 package unaliased,saturation.NewAnalyzer()in that file resolved to the imported package; easy to misread. After this rename, the only remainingpackage saturationis the Engine, so the ambiguity is gone.V1 is deliberately not moved under
internal/engines/analyzers/alongside throughput/queueing-model/saturation-v2: unlike those, V1 does not implement theAnalyzerinterface (its surface isAnalyzeModelSaturation/CalculateSaturationTargets), so grouping it there would imply a peer relationship that doesn't exist. It stays the default analyzer path; eventual removal is tracked in #1441.Pre-review Checklist
Release Note
Docs
Verification for reviewers: git tracks all 3 as renames (history preserved); the moved files are byte-identical to their originals except the
packageline; the only remainingpackage saturationisinternal/engines/saturation; no staleinternal/saturationreferences anywhere.go build,go vet,gofmt -l(clean),make lint(0 issues), and the full non-e2ego testsuite all pass.