deploy: default BENCHMARK_MODE to false#610
Merged
ev-shindin merged 2 commits intollm-d:mainfrom Jan 20, 2026
Merged
Conversation
Change the default value of BENCHMARK_MODE from "true" to "false" and add clarification that istioBench env is required in helmfile when enabling benchmark mode. Also update the CI e2e OpenShift workflow to explicitly set BENCHMARK_MODE=false since the istioBench environment is not available in the llm-d helmfile.
Collaborator
Author
|
/ok-to-test |
Contributor
|
🚀 E2E tests triggered by /ok-to-test |
Contributor
Contributor
|
/retest |
Contributor
|
🚀 E2E tests triggered by /retest |
Increase requestsPerWorker from 1000 to 1100 for Model A1 and from 500 to 550 for Model B (10% increase) to sustain load slightly longer through scale-up while staying within job completion timeout.
Collaborator
Author
|
/retest |
Contributor
|
🚀 E2E tests triggered by /retest |
Collaborator
|
Since |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BENCHMARK_MODEfrom"true"to"false"in the install scriptistioBenchenvironment is required in helmfile when enabling benchmark modeBENCHMARK_MODE=falsein CI e2e OpenShift workflowBackground
The
BENCHMARK_MODEsetting switches the Istio gateway configuration to use theistioBenchenvironment in the llm-d helmfile. However, this environment is not available in the standard llm-d helmfile, causing deployment failures when benchmark mode is enabled by default.Changes
deploy/install.sh: Changed default from"true"to"false"and updated comment to clarify theistioBenchrequirement.github/workflows/ci-e2e-openshift.yaml: Added explicitBENCHMARK_MODE: "false"to both Model A1 and Model B deployment steps to ensure CI reliabilityTest plan
BENCHMARK_MODE=truewhenistioBenchenvironment is available