Fix: OpenShift E2E Workflow Not Running#637
Merged
lionelvillard merged 1 commit intollm-d:mainfrom Jan 26, 2026
Merged
Conversation
The duplicate BENCHMARK_MODE definitions in the same env blocks caused GitHub Actions to reject the workflow file with error: 'BENCHMARK_MODE' is already defined Removes duplicate definitions at lines 479 and 536 while keeping the original definitions at lines 468 and 521.
Collaborator
Author
|
/ok-to-test |
Collaborator
|
Duplicate of #631 Let's merge this one first as it only fixes the CI workflow file. @WheelyMcBones can you then rebase you PR? |
lionelvillard
approved these changes
Jan 26, 2026
Collaborator
|
@lionelvillard just rebased #631 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
CI - OpenShift E2E Testsworkflow which was completely broken due to duplicate environment variable definitions causing GitHub Actions to reject the workflow file.Problem
The OpenShift E2E workflow (
.github/workflows/ci-e2e-openshift.yaml) was not running on any PRs. GitHub Actions was rejecting the workflow file with the error:This prevented the entire workflow from executing, which is why:
/ok-to-testcomments had no effectRoot Cause
Two
envblocks in the workflow had duplicateBENCHMARK_MODEdefinitions:"Deploy WVA and llm-d infrastructure" step (lines 462-491):
BENCHMARK_MODE: "false"(original)BENCHMARK_MODE: "false"(duplicate)"Deploy Model B infrastructure" step (lines 515-548):
BENCHMARK_MODE: "false"(original)BENCHMARK_MODE: "false"(duplicate)YAML does not allow duplicate keys in the same mapping, and GitHub Actions enforces this validation.
Fix
Removed the duplicate
BENCHMARK_MODEdefinitions at lines 479 and 536, keeping the original definitions at lines 468 and 521.