Skip to content

Fix: OpenShift E2E Workflow Not Running#637

Merged
lionelvillard merged 1 commit intollm-d:mainfrom
ev-shindin:fix/openshift-workflow-duplicate-env
Jan 26, 2026
Merged

Fix: OpenShift E2E Workflow Not Running#637
lionelvillard merged 1 commit intollm-d:mainfrom
ev-shindin:fix/openshift-workflow-duplicate-env

Conversation

@ev-shindin
Copy link
Copy Markdown
Collaborator

Summary

Fixes the CI - OpenShift E2E Tests workflow which was completely broken due to duplicate environment variable definitions causing GitHub Actions to reject the workflow file.

Problem

The OpenShift E2E workflow (.github/workflows/ci-e2e-openshift.yaml) was not running on any PRs. GitHub Actions was rejecting the workflow file with the error:

Invalid workflow file: .github/workflows/ci-e2e-openshift.yaml#L1
(Line: 479, Col: 11): 'BENCHMARK_MODE' is already defined
(Line: 536, Col: 11): 'BENCHMARK_MODE' is already defined

This prevented the entire workflow from executing, which is why:

  • No OpenShift E2E checks appeared in PR status
  • /ok-to-test comments had no effect
  • The workflow appeared to be completely inactive

Root Cause

Two env blocks in the workflow had duplicate BENCHMARK_MODE definitions:

  1. "Deploy WVA and llm-d infrastructure" step (lines 462-491):

    • Line 468: BENCHMARK_MODE: "false" (original)
    • Line 479: BENCHMARK_MODE: "false" (duplicate)
  2. "Deploy Model B infrastructure" step (lines 515-548):

    • Line 521: BENCHMARK_MODE: "false" (original)
    • Line 536: BENCHMARK_MODE: "false" (duplicate)

YAML does not allow duplicate keys in the same mapping, and GitHub Actions enforces this validation.

Fix

Removed the duplicate BENCHMARK_MODE definitions at lines 479 and 536, keeping the original definitions at lines 468 and 521.

The duplicate BENCHMARK_MODE definitions in the same env blocks caused
GitHub Actions to reject the workflow file with error:
'BENCHMARK_MODE' is already defined

Removes duplicate definitions at lines 479 and 536 while keeping the
original definitions at lines 468 and 521.
@ev-shindin
Copy link
Copy Markdown
Collaborator Author

/ok-to-test

@lionelvillard
Copy link
Copy Markdown
Collaborator

Duplicate of #631

Let's merge this one first as it only fixes the CI workflow file. @WheelyMcBones can you then rebase you PR?

@lionelvillard lionelvillard merged commit 578f92b into llm-d:main Jan 26, 2026
9 checks passed
@WheelyMcBones
Copy link
Copy Markdown
Collaborator

@lionelvillard just rebased #631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants