🐛 fix: report e2e commit status to fork PR head SHA#840
Merged
clubanderson merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
When /trigger-e2e-full is commented on a fork PR, the issue_comment event always associates the workflow run with main (GitHub limitation). Without explicit status reporting, the PR shows no e2e check status, making it appear the tests ran against main. Fix: - Add report-status job that calls repos.createCommitStatus on the PR head SHA after e2e-tests complete (mirrors ci-e2e-openshift.yaml) - Add pending status step at e2e-tests start for immediate PR feedback - Replace GITHUB_SHA with pr_head_sha in image tag so logs show the actual code being tested - Add statuses:write permission to e2e-tests and report-status jobs Closes #831 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
GPU Pre-flight Check ✅GPUs are available for e2e-openshift tests. Proceeding with deployment.
|
mamy-CS
approved these changes
Mar 4, 2026
Collaborator
mamy-CS
left a comment
mamy-CS
left a comment
There was a problem hiding this comment.
Thank you @clubanderson I was just looking at this issue. /lgtm
Contributor
Author
|
@mamy-CS please test and report findings in slack so we know today if this works or not. |
zdtsw
added a commit
to zdtsw-forking/workload-variant-autoscaler
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
/trigger-e2e-fullis commented on a fork PR, theissue_commentevent always associates the workflow run withmain(GitHub limitation). The previous fixes (PR #832, PR #839) correctly fixed the code checkout to use the PR's head SHA, but no commit status was reported back to the PR. This means:/trigger-e2e-fullmain's SHA, making it appear tests ran against mainFix
Mirrors the pattern already used in
ci-e2e-openshift.yaml:report-statusjob: Runs aftere2e-testsforissue_commentevents, callsrepos.createCommitStatus()on the PR head SHA with the test result (success/failure)pendingcommit status on the PR head SHA when e2e-tests starts, giving immediate feedbackGITHUB_SHAwithpr_head_shain the image tag so logs show the actual code being builtstatuses: writepermission: Added toe2e-testsandreport-statusjobsTesting
ci-e2e-openshift.yamlimplementationCloses #831