Skip to content

cleanup: remove unused BENCHMARK_MODE var in install scripts#859

Merged
lionelvillard merged 1 commit intollm-d:mainfrom
shuynh2017:shuynh_remove_unused_var
Mar 10, 2026
Merged

cleanup: remove unused BENCHMARK_MODE var in install scripts#859
lionelvillard merged 1 commit intollm-d:mainfrom
shuynh2017:shuynh_remove_unused_var

Conversation

@shuynh2017
Copy link
Copy Markdown
Collaborator

@shuynh2017
Copy link
Copy Markdown
Collaborator Author

cc @WheelyMcBones

@WheelyMcBones
Copy link
Copy Markdown
Collaborator

Thank you for your PR @shuynh2017
Other env vars that could probably be removed in following PRs are LLM_D_INFERENCE_SIM_IMG_REPO and LLM_D_INFERENCE_SIM_IMG_TAG

@WheelyMcBones
Copy link
Copy Markdown
Collaborator

/ok-to-test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

🚀 OpenShift E2E — approve and run (/ok-to-test)

View the OpenShift E2E workflow run

@WheelyMcBones
Copy link
Copy Markdown
Collaborator

/trigger-e2e-full

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

🚀 Kind E2E (full) triggered by /trigger-e2e-full

View the Kind E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

GPU Pre-flight Check ✅

GPUs are available for e2e-openshift tests. Proceeding with deployment.

Resource Total Allocated Available
GPUs 50 11 39
Cluster Value
Nodes 16 (7 with GPUs)
Total CPU 993 cores
Total Memory 10383 Gi
GPUs required 4 (min) / 6 (recommended)

Copy link
Copy Markdown
Collaborator

@WheelyMcBones WheelyMcBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shuynh2017
Copy link
Copy Markdown
Collaborator Author

Thank you for your PR @shuynh2017 Other env vars that could probably be removed in following PRs are LLM_D_INFERENCE_SIM_IMG_REPO and LLM_D_INFERENCE_SIM_IMG_TAG

@WheelyMcBones thank you. I will review, remove, test in following PRs.

@lionelvillard lionelvillard merged commit 4af3ef9 into llm-d:main Mar 10, 2026
28 checks passed
@shuynh2017
Copy link
Copy Markdown
Collaborator Author

Cleaning up capture in new epic: #872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants