Skip to content

Chore: Deprecate desiredOptimizedAlloc.accelerator#955

Merged
github-actions[bot] merged 9 commits intollm-d:mainfrom
shuynh2017:shuynh_dep_accel
Mar 31, 2026
Merged

Chore: Deprecate desiredOptimizedAlloc.accelerator#955
github-actions[bot] merged 9 commits intollm-d:mainfrom
shuynh2017:shuynh_dep_accel

Conversation

@shuynh2017
Copy link
Copy Markdown
Collaborator

@shuynh2017 shuynh2017 commented Mar 30, 2026

Requirements: #809
Proposal: #809 (comment)

  • We will first mark as deprecated (soft deprecation) with message what to use instead of this deprecated field.

Deprecating a required field in a Kubernetes CRD with Kubebuilder involves a multi-step process for backward compatibility, primarily by relaxing the requirement in the current version and marking it as deprecated, or by introducing a new API version

  • Once this PR is approved, we open an issue to remove it (breaking change) for the next API version bump.

Notes:

  • Kubebuilder has this annotation // +kubebuilder:deprecatedversion:warning=, but this is for the whole api, not for just a field.
  • The annotation Deprecated used in this PR is according to recommended practice.
  • The only visible change to users is:
$ kubectl explain VariantAutoscaling.status.desiredOptimizedAlloc
GROUP:      llmd.ai
KIND:       VariantAutoscaling
VERSION:    v1alpha1

FIELD: desiredOptimizedAlloc <Object>


DESCRIPTION:
    DesiredOptimizedAlloc indicates the target optimized allocation based on
    autoscaling logic.

FIELDS:
  accelerator   <string>
    Accelerator is the type of accelerator for the optimized allocation.
    Deprecated: This field is deprecated and will be removed in a future                 <=====
    version. Use node selector or node affinity from scale target instead.

  lastRunTime   <string>
    LastRunTime is the timestamp of the last optimization run.

  numReplicas   <integer>
    NumReplicas is the number of replicas for the optimized allocation.
    nil means no optimization decision has been made yet.

@shuynh2017
Copy link
Copy Markdown
Collaborator Author

@ev-shindin. Pls help to review. Thanks.

@shuynh2017 shuynh2017 requested a review from ev-shindin March 30, 2026 16:23
Copy link
Copy Markdown
Collaborator

@ev-shindin ev-shindin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at my comment. Also ensure that both CRD YAML files are generated by make manifests from the Go types + kubebuilder markers.

@shuynh2017
Copy link
Copy Markdown
Collaborator Author

/ok-to-test

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Kind E2E (full) triggered by /ok-to-test

View the Kind E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

🚀 OpenShift E2E — approve and run (/ok-to-test)

View the OpenShift E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

GPU Pre-flight Check ✅

GPUs are available for e2e-openshift tests. Proceeding with deployment.

Resource Total Allocated Available
GPUs 50 31 19
Cluster Value
Nodes 16 (7 with GPUs)
Total CPU 993 cores
Total Memory 10383 Gi
GPUs required 4 (min) / 6 (recommended)

ev-shindin
ev-shindin previously approved these changes Mar 31, 2026
@shuynh2017
Copy link
Copy Markdown
Collaborator Author

/ok-to-test

@github-actions
Copy link
Copy Markdown
Contributor

🚀 Kind E2E (full) triggered by /ok-to-test

View the Kind E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

🚀 OpenShift E2E — approve and run (/ok-to-test)

View the OpenShift E2E workflow run

@github-actions
Copy link
Copy Markdown
Contributor

GPU Pre-flight Check ✅

GPUs are available for e2e-openshift tests. Proceeding with deployment.

Resource Total Allocated Available
GPUs 50 30 20
Cluster Value
Nodes 16 (7 with GPUs)
Total CPU 993 cores
Total Memory 10383 Gi
GPUs required 4 (min) / 6 (recommended)

Copy link
Copy Markdown
Collaborator

@ev-shindin ev-shindin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks!

@lionelvillard
Copy link
Copy Markdown
Collaborator

/lgtm

@github-actions github-actions bot added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Mar 31, 2026
@github-actions github-actions bot merged commit e0ed956 into llm-d:main Mar 31, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Looks good to me, indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants