Chore: Deprecate desiredOptimizedAlloc.accelerator#955
Merged
github-actions[bot] merged 9 commits intollm-d:mainfrom Mar 31, 2026
Merged
Chore: Deprecate desiredOptimizedAlloc.accelerator#955github-actions[bot] merged 9 commits intollm-d:mainfrom
github-actions[bot] merged 9 commits intollm-d:mainfrom
Conversation
Collaborator
Author
|
@ev-shindin. Pls help to review. Thanks. |
ev-shindin
requested changes
Mar 30, 2026
Collaborator
ev-shindin
left a comment
There was a problem hiding this comment.
Look at my comment. Also ensure that both CRD YAML files are generated by make manifests from the Go types + kubebuilder markers.
Collaborator
Author
|
/ok-to-test |
Contributor
|
🚀 Kind E2E (full) triggered by |
Contributor
|
🚀 OpenShift E2E — approve and run ( |
Contributor
GPU Pre-flight Check ✅GPUs are available for e2e-openshift tests. Proceeding with deployment.
|
ev-shindin
previously approved these changes
Mar 31, 2026
Collaborator
Author
|
/ok-to-test |
Contributor
|
🚀 Kind E2E (full) triggered by |
Contributor
|
🚀 OpenShift E2E — approve and run ( |
Contributor
GPU Pre-flight Check ✅GPUs are available for e2e-openshift tests. Proceeding with deployment.
|
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements: #809
Proposal: #809 (comment)
Notes:
// +kubebuilder:deprecatedversion:warning=, but this is for the whole api, not for just a field.Deprecatedused in this PR is according to recommended practice.