Closed
Conversation
- engine_test.go change type Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Go typecheck/lint failure in the scale-from-zero engine unit test by updating it to use the new scaletarget.ScaleTargetAccessor map type, plus minor formatting cleanup.
Changes:
- Update
internal/engines/scalefromzero/engine_test.goto passmap[string]scaletarget.ScaleTargetAccessor(viascaletarget.NewDeploymentAccessor) intoprocessInactiveVariant. - Apply gofmt/whitespace cleanup in a few files (remove trailing blank line, align struct literal fields).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scale_from_zero_test.go | Removes trailing blank line at EOF (formatting only). |
| internal/engines/scalefromzero/engine_test.go | Fixes test compilation by using ScaleTargetAccessor map for processInactiveVariant. |
| internal/engines/pipeline/greedy_score_optimizer_test.go | Gofmt alignment in test struct literal fields. |
| internal/engines/pipeline/enforcer.go | Removes trailing blank line at EOF (formatting only). |
| internal/config/saturation_scaling.go | Minor gofmt alignment in struct tag comment spacing. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Error: internal/engines/scalefromzero/engine_test.go:481:46: cannot use deployments (variable of type map[string]*"k8s.io/api/apps/v1".Deployment) as map[string]scaletarget.ScaleTargetAccessor value in argument to engine.processInactiveVariant (typecheck)ref LeaderWorkerSet Support #910cc @shuynh2017